No, it looks good, the interface is unchanged and the behavior is unchanged, so it is still "refactoring" ;-) , so that was my main point of interest for the moment, I still think we can clean up this interface so it always returns a dictoniary where the general comments could be in path "general" or linenr "0" or something like that, but that is mainly the part I wanted to "leave for later" ;-)
Thx for taking it in, now I can continue! br, Jan On Thu, Apr 30, 2015 at 7:42 PM, Mads Kiilerich <[email protected]> wrote: > On 04/30/2015 07:06 AM, Jan Heylen wrote: >> >> # HG changeset patch >> # User Jan Heylen <[email protected]> >> # Date 1430370318 -7200 >> # Thu Apr 30 07:05:18 2015 +0200 >> # Node ID 406c95a068096edec2b8ffdedf2a0d1caced14a4 >> # Parent 71140b7c9abfcb34db70792c39e09a4e4796efb1 >> ChangesetCommentsModel: refactor duplicate code > > > I worked this and addressed some of the comments you had "left for later". I > hope that is ok. > > /Mads > _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
