auth: return early in LoginRequired on API key validation Simplify the logic in the LoginRequired decorator when Kallithea is accessed using an API key. Eit...
patrickdp committed on 2015-03-30 19:27:02
branch: default tag: tip changeset: e04106e4 auth: return early in LoginRequired on API key validation Simplify the logic in the LoginRequired decorator when Kallithea is accessed using an API key. Either: - the key is valid and API access is allowed for the accessed method (continue), or - the key is invalid (redirect to login page), or - the accessed method does not allow API access (403 Forbidden) In none of these cases does it make sense to continue checking for user authentication, so return early. M kallithea/lib/auth.py (18 lines added, 20 lines removed) M kallithea/tests/functional/test_login.py (1 lines added, 1 lines removed) |
_______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
