tests: improve robustness of notifications tests The notifications tests make the assumption that there are no notifications at the start of the test, which...

patrickdp committed on 2015-06-22 12:56:01
branch: default
tag: tip
changeset: ac5d236a
tests: improve robustness of notifications tests

The notifications tests make the assumption that there are no notifications
at the start of the test, which is explicitly asserted.

However, any other test, like the one introduced in commit 9a23b444a7fe
(pullrequests: detect invalid reviewers and raise HTTPBadRequest), could add
new notifications to the database, and thus fail these assertions.

Just like the notifications tests already cleaned all notifications at the
end of the test (tearDown), make sure to clean them at the start (setUp)
too.

 M kallithea/tests/models/test_notifications.py (3 lines added, 1 lines removed)
_______________________________________________
kallithea-general mailing list
kallithea-general@sfconservancy.org
http://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Reply via email to