On Wed, Mar 2, 2016 at 9:20 PM, Thomas De Schampheleire <[email protected]> wrote: > On Tue, Mar 1, 2016 at 1:38 PM, Angel Ezquerra <[email protected]> > wrote: >> On Mon, Feb 29, 2016 at 1:27 PM, Thomas De Schampheleire >> <[email protected]> wrote: > [..] >>>> Thomas: you implemented this helper function. Now it is growing a bit more >>>> complex - please review and approve these changes ... and comment on the >>>> general thoughts on when to count what. >>> >>> Yes, I was planning to test and review these changes. >>> >>> Since I wrote these changes, I am more and more convinced that the >>> amount of logic in templates should be as limited as possible, and >>> instead the model or controller should provide the information. Right >>> now this is possible by creating some function/property; but note that >>> it may become trickier when we actually want to properly count inline >>> comments which are added via ajax. >> >> I'm not quite sure, from your comment, whether you think I should >> change the patch to put the logic on a separate function or not. >> Please advise! :-) >> > > I would create a function in the model now, and fix the ajax later.
Btw, I kind of lost track of the pending patches and whether or not they are waiting for comments or waiting for you to resubmit. Could you give a brief overview? Thanks, Thomas _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
