On Aug 2, 2016 22:13, "Mads Kiilerich" <[email protected]> wrote: > > On 08/02/2016 10:03 PM, Thomas De Schampheleire wrote: >> >> On Tue, Aug 2, 2016 at 9:38 PM, Mads Kiilerich <[email protected]> wrote: >>> >>> On 08/02/2016 09:30 PM, Thomas De Schampheleire wrote: >>>> >>>> Hi Mads, >>>> >>>> Since commit >>>> changeset: 6084:552800808386 >>>> user: Mads Kiilerich <[email protected]> >>>> date: Thu Jul 28 16:31:40 2016 +0200 >>>> summary: tests: add test coverage of PR comment @mention >>>> >>>> I get test failures on the e-mail tests, due to escaping of single quotes. >>>> It is unclear to me how your change is causing this, but it is 100% >>>> deterministic. >>>> >>>> Do you have a clue? >>>> >>>> The type of diff between out and ref, is: >>>> >>>> E - ation. Don\'t reply to this mail. >>>> E ? - >>>> E + ation. Don't reply to this mail. > > > Is it failing like that on all the text mails, or only the new one related to this change?
On all. > > I think my answer must be that I have no clue and don't have the problem. Please, you can reproduce the problem - can you dive into it? What I already tried: - remove the added comments (FIXME) from the commit - remove the addition of the is_mention clause. With these changes, the problem still occurred. Reverting the changes in ref too fixes the problem. What I don't recall is whether the html files itself were fine or not -- perhaps the problem is in the comparison by pytest. I can't continue on this tonight, I can see if I can find more later, unless Dominik found it by then. /Thomas
_______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
