On Wed, Sep 14, 2016 at 1:16 AM, Mads Kiilerich <[email protected]> wrote: > On 09/13/2016 09:20 PM, Thomas De Schampheleire wrote: >> >> All, >> >> I sent out a few changes for review at: >> >> https://kallithea-scm.org/repos/kallithea/pull-request/60/_/Turbogears2_migration_preparatory_commits >> >> These commits are originating from the tg2 branch, and can already be >> applied on current Pylons-based Kallithea. Goal of this delivery is to >> make the 'real' Turbogears2 migration a smaller, more clear diff. >> >> Turbogears2 migration: replace pylons.url by kallithea.lib.utils.url >> Turbogears2 migration: use sqlalchemy.url iso sqlalchemy.db1.url >> Turbogears2 migration: remove some references to Pylons in comments >> >> Comments welcome, > > > My immediate comment: This is a beautiful example of how bits and pieces of > a big and almost-impossible-to-review amount of work can be extracted into > clean patches and how it can make it possible to review both this and the > remaining part much more efficiently and reliably. Thanks! >
(thanks for that comment btw!) I sent out a second iteration of these changes, incorporating the comments: https://kallithea-scm.org/repos/kallithea/pull-request/61/_/Turbogears2_migration_preparatory_commits_v2 _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
