On Sun, Sep 25, 2016 at 3:12 PM, Mads Kiilerich <[email protected]> wrote: > On 09/25/2016 02:54 PM, Thomas De Schampheleire wrote: >> >> I had a brief look at the model imports from lib.helpers and lib.utils >> and lib.utils2, but it doesn't look like my cup of tea to untangle >> this, that is I don't know any of these functions and what is the >> right thing to do. I can only semi-blindly follow your advice and >> execute the work. > > > > Yeah, I also don't know. I guess it will be some amount of trial and error > to figure out where the cuts can be made ... and where they can't. We will > probably have to introduce some non-module-global imports - at least > temporarily. Some existing non-module-global imports can probably also be > made global. I guess first round will suggest some other refactorings to do > first ... and the first attempt will be a learning experience that will have > to be discarded before doing it for real. >
As first step, I just moved the code from model/__init__.py to a new model/base.py. I'll send it later. Doesn't solve the recursive import by itself though... Btw, found the reason why I didn't see the backtrace: was still using pytest 2.9.2, switching to pytest 3.+ did the trick. Three cheers for pytest 3! _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
