On Fri, Apr 6, 2018, 08:34 Thomas De Schampheleire < [email protected]> wrote:
> > > On Thu, Apr 5, 2018, 22:56 Dominik Ruf <[email protected]> wrote: > >> >> >> Dominik Ruf <[email protected]> schrieb am Di., 27. März 2018 um >> 23:17 Uhr: >> >>> >>> >>> On Tue, Mar 27, 2018, 21:07 Thomas De Schampheleire < >>> [email protected]> wrote: >>> >>>> 2018-03-26 19:07 GMT+02:00 Dominik Ruf <[email protected]>: >>>> > Hi again, >>>> > >>>> > and thanks again for the feedback last time. >>>> > I made some progress and would love to hear what you think about it. >>>> > https://kallithea-exp.dominikruf.com/kallithea/kallithea >>>> > >>>> https://kallithea-exp.dominikruf.com/kallithea/kallithea-domruf/changelog >>>> > >>>> >>>> On mobile phone, the sidebar is hidden by default (which is fine). >>>> Clicking the menu button on the second navbar makes it visible (also >>>> fine) but then: when you click the menu button again, there is an >>>> animation of the sidebar 'rolling up', and it takes too long IMO. It >>>> is not as quick as the expansion, and makes it feel sluggish. >>>> >>> This is the default animation of bootstrap. I thought about that myself >>> but it didn't bother me enough to change it yet :-D >>> >>>> >>>> Other than that, it looks nice, both on mobile as on desktop. (on >>>> mobile there are some general non-ideal points but not specific to the >>>> sidebar). >>>> >>>> I like the 'number of pullrequests' overlay on the PR button, but I do >>>> wonder how it will look like if the number is 2 or even 3 digits long. >>>> >>> It think it looks good with 2 digits and if you have more then 100 open >>> pull requests I believe there is something wrong with your project. :-D >>> BTW you can see how it looks by simply changing the text with the >>> debugger of your browser. >>> >>>> >>>> The '@' sign to indicate the revision in plain text seems a bit >>>> unprofessional. I think it could be improved in some way, but not sure >>>> how. Perhaps with an 'at' icon. >>>> >>> I don't like the font for the revision hash (and @). I'm not sure what >>> you mean by an 'at' icon though. >>> >> Can you tell me a bit more what you mean by "an 'at' icon" ? >> BTW I worked a bit more on it and now all the pages use the new look. (I >> hope I didn't forget one) And the animation should be fix now. >> https://kallithea-exp.dominikruf.com >> > > Sorry I forgot to reply on the at. What I meant was to use an at symbol > from fontello. I searched there and found several at symbols which are a > bit bolder than the normal bold text. I think that looks nicer. > Okay. I'm not sure the @ would look that much different/better as an icon. I searched at fontello but did not find one that I liked. Can you send a link to the one you meant? Also note that I changed the color to match the breadcrumb separater and I made it bold as well. I quite like it that way.
_______________________________________________ kallithea-general mailing list [email protected] https://lists.sfconservancy.org/mailman/listinfo/kallithea-general
