On 10/8/18 9:57 PM, Thomas De Schampheleire wrote:
# HG changeset patch
# User Thomas De Schampheleire <[email protected]>
# Date 1538510861 -7200
#      Tue Oct 02 22:07:41 2018 +0200
# Node ID 6ecaf9e33bbfa23943b488cc3a24b69dff6ed1c0
# Parent  14d0a7fc45f3c5dd7333d3f93335d5b556e7c4f0
cli: convert 'gearbox celeryd' into 'kallithea-cli celery run'

Notes:
- '--' is never explicitly present in the arguments, this is covered by
   click.


If mentioning this, perhaps make it more explicit that the click parser will take care of '--' as separator between dash-dash-arguments and positional arguments (which might start with dash-dash too).


- the changes in cmd.run_from_argv are done to get correct help and error
   message output.


I guess that could be fixed first. But ok, a very minor and trivial thing that I'm fine with having in this changeset.



diff --git a/docs/setup.rst b/docs/setup.rst
--- a/docs/setup.rst
+++ b/docs/setup.rst
@@ -307,7 +307,7 @@ Celery. So for example setting `BROKER_H
To start the Celery process, run:: - gearbox celeryd -c <configfile.ini>
+  kallithea-cli celery run <configfile.ini>


(I notice we don't use the <configfile.ini> notation in any other places. Perhaps as a separate change, make it the usual example of my.ini.)


/Mads
_______________________________________________
kallithea-general mailing list
[email protected]
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Reply via email to