On 12/11/18 10:13 AM, Thomas De Schampheleire wrote:
kallithea_1  |   File "./kallithea/lib/vcs/backends/hg/repository.py",
line 295, in _check_url
kallithea_1  |     sshpeer(repoui or ui.ui(), url).lookup('tip')
kallithea_1  | TypeError: __init__() takes at least 8 arguments (3 given)
kallithea_1  | 2018-12-11 09:05:07.596 INFO
[kallithea.controllers.admin.repos] Invalid repository URL


One of the annoying `except Exception` :-(


It's been a while that I tested this, but I wonder if it could be
related to a mercurial version? This instance is running 4.7.2.
In commit 03dfcbe52906 there has been a change in this area, but I
didn't investigate it further.


Yes, that change was insufficient.

Proposed fix on https://kallithea-scm.org/repos/kallithea-incoming/changeset/8107a49198fbbb1474f84cc0e6c8c1cfea5d2de4

Extra annoying that it just fails in a URL validation check. The actual clone works ... and it would fail if the URL was invalid. So it would perhaps be better to drop the check and just try it, similar to how ssh URLs are handled?

Also, it would be nice to have test coverage for this ;-)


/Mads


_______________________________________________
kallithea-general mailing list
kallithea-general@sfconservancy.org
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Reply via email to