On 2/8/20 11:10 PM, Ross Thomas wrote:
On 2/8/20 7:10 AM, Mads Kiilerich wrote:
It would be nice to have more details in the commit message explaining
what the intent is, so we don't have to reverse engineer it. We want to
review that we are aligned on the intent, and that the change is a
maintainable and good / best way to implement the intent.
Apologies. I had meant to add this:
Thanks. (Also, I had missed the intro mail - that gave a bit more context.)
I'm not done processing the mail and PR. But I wonder if there are some
existing root causes that we perhaps could fix, instead of adding a
workaround. Extra shortcuts are a bad substitute for getting it right.
I agree that having the "follow" indicator in the repo listing is a
relevant duplication. And when the indicator is shown, we can just as
well make it active so it can be used for toggling. Le's do that. My
concern is only about duplication of the other icons.
* Some "repo actions" (such as "Delete") are hidden under "Settings". We
should clean up and put things where they belong. Perhaps directly on
the repo page ... or at least less deep.
* The repo "Options" menu is odd. All entries in it should perhaps be
elsewhere, grouped and named differently, and perhaps directly available
on the repo page - not hidden in a menu.
Some meta actions/settings should perhaps "belong" in the repo list, and
not inside the repo (as long as it also is easy to get to get the same
thing when already looking at the repo). The most obvious "actions" are:
Create (already in the repo list), Create-by-forking-this, and Delete.
Rename and Move could be seen as meta actions, but could also be seen as
settings on the repo. Permissions could perhaps also be seen as a meta
thing ... but that would really put us on a slippery slope where
everything has to move out, so let's not go that far.
/Mads
_______________________________________________
kallithea-general mailing list
[email protected]
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general
