On Tue, 4 Dec 2001 19:54:41 -0500, Ghozlane Toumi <[EMAIL PROTECTED]> wrote: >in arch/i386/Makefile.defs.config >why do you use code like > >ifneq ($(subst n,,$(CONFIG_M386)),) > CFLAGS += -march=i386 >endif > >rather than > >ifeq($(CONFIG_M386),y) > CFLAGS += -march=i386 >endif
ifeq(,y) only tests for the built in case and does not handle modules. ifneq ($(subst n,,$(CONFIG_foo)),) is false for n or blank, and true for everything else. ifsel() expands into the latter format. For boolean variables like CONFIG_M386, ifeq(,y) is "good enough" but it risks people doing cut and paste and using the wrong construct for tristate variables, so use the right syntax for all variables. _______________________________________________ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
