On Thu, Dec 20, 2001 at 12:25:03PM +1100, Keith Owens wrote: > On Thu, 20 Dec 2001 09:45:16 +1100, > Keith Owens <[EMAIL PROTECTED]> wrote: > >On Wed, 19 Dec 2001 13:27:19 -0700, > >Tom Rini <[EMAIL PROTECTED]> wrote: > >>On PPC, the APUS platform (which is an m68k + PPC upgrade), we need to > >>include a bunch of m68k headers. How should this be done w/ kbuild-2.5? > > > >Try this (untested). It should create a symlink for asm-m68k under > >$KBUILD_OBJTREE/.tmp_include/src_000/. > > > >Index: 16.35/Makefile-2.5 > >--- 16.35/Makefile-2.5 Sun, 16 Dec 2001 01:01:02 +1100 kaos >(linux-2.4/E/d/40_Makefile-2 1.32.2.14 644) > >+++ 16.35(w)/Makefile-2.5 Thu, 20 Dec 2001 09:40:31 +1100 kaos >(linux-2.4/E/d/40_Makefile-2 1.32.2.14 644) > >@@ -94,6 +94,12 @@ export KBUILD_WRITABLE check_writable > > > > # A list of directories under linux/include to scan, excluding asm-$(ARCH). > > KBUILD_INCLUDE_DIRS := linux math-emu net pcmcia scsi video asm-generic > >+# The APUS platform (m68k + PPC upgrade) needs to include a bunch of m68k > >+# headers via #include <asm-m68k/xxx.h>. Why, oh why do they do these things? > >+# Since .config is not available yet, add asm-m68k for all PPC platforms. > >+ifeq ($(ARCH),ppc) > >+ KBUILD_INCLUDE_DIRS += asm-m68k > >+endif > > > > # Unfortunately the make 'export' command only applies to commands in rules. > > # Exported variables are not available to $(shell) commands, at least up to > > Tom, please back out the patch above and try this one. It restricts > the extra include path to apus only instead of adding asm-m68k for all > ppc compiles. May as well isolate the broken code as much as possible.
I don't know if this is any better really, since it adds #ifdef CONFIG_APUS #include <asm/amigafoo.h> #endif. And since APUS doesn't currently compile (@#!@$) anyways, I can't see if the includes are now bogus. So I think for now we should be overly cautious and always do asm-m68k. -- Tom Rini (TR1265) http://gate.crashing.org/~trini/ _______________________________________________ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
