Having spent a non trivial amount of time trying to pull in the 
code to enable MSI, I would suggest that a clear indication in 
Kconfig that MSI requires CONFIG_PCI_USE_VECTOR would be very helpful.
Also since the MSI code was integrated into 2.6.1 I've updated the 
comment that called for installing the MSI patch.
Martine
--- linux-2.6.3-rc2/arch/i386/Kconfig   2004-02-09 22:00:27.000000000 -0500
+++ linux-2.6.3-rc2_mine/arch/i386/Kconfig      2004-02-12 14:24:37.000000000 -0500
@@ -1056,7 +1056,7 @@
        default y
 
 config PCI_USE_VECTOR
-       bool "Vector-based interrupt indexing"
+       bool "Vector-based interrupt indexing (MSI)"
        depends on X86_LOCAL_APIC && X86_IO_APIC
        default n
        help
@@ -1066,11 +1066,11 @@
           1) Support MSI implementation.
           2) Support future IOxAPIC hotplug
 
-          Note that this enables MSI, Message Signaled Interrupt, on all
-          MSI capable device functions detected if users also install the
-          MSI patch. Message Signal Interrupt enables an MSI-capable
-          hardware device to send an inbound Memory Write on its PCI bus
-          instead of asserting IRQ signal on device IRQ pin.
+          Note that this allows the device drivers to enable MSI, Message 
+          Signaled Interrupt, on all MSI capable device functions detected.
+          Message Signal Interrupt enables an MSI-capable hardware device to
+          send an inbound Memory Write on its PCI bus instead of asserting
+          IRQ signal on device IRQ pin.
 
           If you don't know what to do here, say N.
 

Reply via email to