On Sun, Aug 15, 2004 at 09:37:30PM +0200, Geert Uytterhoeven wrote:
> On Sun, 15 Aug 2004, Roman Zippel wrote:
> > On Sat, 14 Aug 2004, Adrian Bunk wrote:
> > > > This is less a problem, as here it's clear that you want a boolean result,
> > > > but something like "FOO=n" is really a string compare and FOO could be of
> > > > any type (that 99% of all symbols are boolean/tristate symbols doesn't
> > > > really help).
> > >
> > > Wouldn't it be better to require a string or hex to always be quoted
> > > like "somestring"?
> >
> > What about normal numbers? I don't think requiring quotes everywhere for
> > this is a good idea.
> 
> And numbers (both decimal and hex) can easily be distinguished from y, n, and m
> anyway.

Sounds reasonable.

This leaves strings.

Could you point me to one single place in the kernel where a string 
constant is used in the dependencies of another symbol?
If it's that rare, requiring quotes shouuldn't be that much of a burden.

I see six places where quotes are used for y/n/m, but they should be 
trivial to fix.

> Gr{oetje,eeting}s,
> 
>                                               Geert

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel

Reply via email to