Pierre Ossman writes: > GCC 4 checks the signedness of pointer casts and generates a whole bunch > of warnings for code in scripts/ (which makes heavy use of signed char > strings). > > This patch adds explicit casts.
This is way ugly. The _real_ bug is that someone decided to store plain text pointers in "signed char*" variables. s/signed char/char/g should be a much better fix. > Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]> > Index: linux-wbsd/scripts/basic/fixdep.c > =================================================================== > --- linux-wbsd/scripts/basic/fixdep.c (revision 134) > +++ linux-wbsd/scripts/basic/fixdep.c (working copy) > @@ -242,7 +242,7 @@ > continue; > > found: > - use_config(p+7, q-p-7); > + use_config((char*)p+7, q-p-7); > } > } > > @@ -296,7 +296,7 @@ > signed char *p; > char s[PATH_MAX]; > > - p = strchr(m, ':'); > + p = (signed char*)strchr((char*)m, ':'); Clearly this is not the way to do text processing in C. ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel
