Hi,
On Thu, 20 Oct 2005, David Gibson wrote:
> When doing its recursive dependency check, scripts/kconfig/conf uses
> the flag SYMBOL_CHECK_DONE to avoid rechecking a symbol it has already
> checked. However, that flag is only set at the top level, so if a
> symbol is first encountered as a dependency of another symbol it will
> be rechecked every time it is encountered until it's encountered at
> the top level.
You're correct, the check does too much.
> Index: working-2.6/scripts/kconfig/symbol.c
> ===================================================================
> --- working-2.6.orig/scripts/kconfig/symbol.c 2005-10-20 12:40:45.000000000
> +1000
> +++ working-2.6/scripts/kconfig/symbol.c 2005-10-20 12:41:43.000000000
> +1000
> @@ -758,6 +758,8 @@
> out:
> if (sym2)
> printf(" %s", sym->name);
> + else
> + sym->flags |= SYMBOL_CHECK_DONE;
> sym->flags &= ~SYMBOL_CHECK;
> return sym2;
> }
Actually this way it becomes redundant with SYMBOL_CHECKED, could you
merge these two flags? The above check would be also probably better:
if (sym2) {
printf(" %s", sym->name);
if (sym2 == sym) {
printf("\n");
sym2 = NULL;
}
}
So that this check will stop when it hits the start symbol and continue
looking for more dependency problems, which is I think I intended with the
original code.
> Index: working-2.6/scripts/kconfig/zconf.y
> ===================================================================
> --- working-2.6.orig/scripts/kconfig/zconf.y 2005-10-20 12:40:45.000000000
> +1000
> +++ working-2.6/scripts/kconfig/zconf.y 2005-10-20 12:41:43.000000000
> +1000
> @@ -495,10 +495,9 @@
> exit(1);
> menu_finalize(&rootmenu);
> for_all_symbols(i, sym) {
> +/* fprintf(stderr, "Checking %s...\n", sym->name); */
One "quilt refresh" missing? :-)
bye, Roman
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
kbuild-devel mailing list
kbuild-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kbuild-devel
