On Tue, 2006-05-23 at 22:17 +0200, Sam Ravnborg wrote:
> On Tue, May 23, 2006 at 12:20:46PM -0500, Dustin Kirkland wrote:
> > Minor changes to allow static analysis checkers besides sparse
> >
> > This patch allows CHECK and CHECKFLAGS to be passed in on the make
> > invocation, such that one could specify a checker other than sparse,
> > and/or different flags.
> This is alread possible.
> Try
> make C=1 CHECK=checker_executable CHECKFLAGS=....
> from your example and see that it works.
No kidding, yep...I just tried that and it worked like a charm. Thanks.
The inline documentation was misleading.
How about this simple patch to more clearly enunciate this in the inline
Makefile documentation?
---
Minor documentation change on allowing checkers besides sparse
This patch cleans up a couple of mentions of sparse in the inline
toplevel Makefile documentation such that it's clear that other checkers
besides sparse can override CHECK and CHECKFLAGS.
Signed-off-by: Dustin Kirkland <[EMAIL PROTECTED]>
---
diff -burpN linux-2.6.17-rc4-mm3/Makefile linux-2.6.17-rc4-mm3-checker/Makefile
--- linux-2.6.17-rc4-mm3/Makefile 2006-05-22 14:12:38.000000000 -0500
+++ linux-2.6.17-rc4-mm3-checker/Makefile 2006-05-23 15:50:25.000000000
-0500
@@ -41,8 +41,9 @@ ifndef KBUILD_VERBOSE
KBUILD_VERBOSE = 0
endif
-# Call sparse as part of compilation of C files
-# Use 'make C=1' to enable sparse checking
+# Call checker as part of compilation of C files
+# Use 'make C=1' to enable checking (sparse, by default)
+# Override with 'make C=1 CHECK=checker_executable CHECKFLAGS=....'
ifdef C
ifeq ("$(origin C)", "command line")
@@ -1068,8 +1069,8 @@ help:
@echo ' make V=0|1 [targets] 0 => quiet build (default), 1 => verbose
build'
@echo ' make O=dir [targets] Locate all output files in "dir",
including .config'
- @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse)'
- @echo ' make C=2 [targets] Force check of all c source with $$CHECK
(sparse)'
+ @echo ' make C=1 [targets] Check all c source with $$CHECK (sparse
by default)'
+ @echo ' make C=2 [targets] Force check of all c source with $$CHECK
(sparse by default)'
@echo ''
@echo 'Execute "make" or "make all" to build all targets marked with
[*] '
@echo 'For further info see the ./README file'
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
_______________________________________________
kbuild-devel mailing list
kbuild-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kbuild-devel
