Hi Daniel,
FYI, there are coccinelle warnings in
tree: git://people.freedesktop.org/~danvet/drm drm-init-cleanup
head: 56abb939d445314fe0148f82f11ea60b5e293056
commit: c994fc0afdfd18e84e287ad3f70e7ecc0b518e74 [23/49] drm: Kill
DRM_COPY_(TO|FROM)_USER
>> drivers/gpu/drm/r128/r128_state.c:1014:10-17: WARNING opportunity for
>> memdup_user
>> drivers/gpu/drm/r128/r128_state.c:1029:9-16: WARNING opportunity for
>> memdup_user
>> drivers/gpu/drm/r128/r128_state.c:904:10-17: WARNING opportunity for
>> memdup_user
>> drivers/gpu/drm/r128/r128_state.c:914:9-16: WARNING opportunity for
>> memdup_user
--
>> drivers/gpu/drm/savage/savage_state.c:1004:13-20: WARNING opportunity for
>> memdup_user
Please consider folding the attached diff :-)
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
From: Dan Carpenter <dan.carpen...@oracle.com>
Subject: [PATCH] drm: use memdup_user() as a cleanup
TO: Daniel Vetter <daniel.vet...@ffwll.ch>
CC: Daniel Vetter <daniel.vet...@ffwll.ch>
CC: linux-ker...@vger.kernel.org
drivers/gpu/drm/r128/r128_state.c:1014:10-17: WARNING opportunity for memdup_user
/c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:1029:9-16: WARNING opportunity for memdup_user
/c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:904:10-17: WARNING opportunity for memdup_user
/c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:914:9-16: WARNING opportunity for memdup_user
Use memdup_user rather than duplicating its implementation
This is a little bit restricted to reduce false positives
Generated by: coccinelle/api/memdup_user.cocci
CC: Daniel Vetter <daniel.vet...@ffwll.ch>
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
---
Please take the patch only if it's a positive warning. Thanks!
cocci-output-8730-4c0e39-r128_state.c | 46 ++++++++--------------------------
1 file changed, 12 insertions(+), 34 deletions(-)
--- a/drivers/gpu/drm/r128/r128_state.c
+++ b/drivers/gpu/drm/r128/r128_state.c
@@ -901,25 +901,16 @@ static int r128_cce_dispatch_write_span(
return -EFAULT;
buffer_size = depth->n * sizeof(u32);
- buffer = kmalloc(buffer_size, GFP_KERNEL);
- if (buffer == NULL)
- return -ENOMEM;
- if (copy_from_user(buffer, depth->buffer, buffer_size)) {
- kfree(buffer);
- return -EFAULT;
- }
+ buffer = memdup_user(depth->buffer, buffer_size);
+ if (IS_ERR(buffer))
+ return PTR_ERR(buffer);
mask_size = depth->n * sizeof(u8);
if (depth->mask) {
- mask = kmalloc(mask_size, GFP_KERNEL);
- if (mask == NULL) {
+ mask = memdup_user(depth->mask, mask_size);
+ if (IS_ERR(mask)) {
kfree(buffer);
- return -ENOMEM;
- }
- if (copy_from_user(mask, depth->mask, mask_size)) {
- kfree(buffer);
- kfree(mask);
- return -EFAULT;
+ return PTR_ERR(mask);
}
for (i = 0; i < count; i++, x++) {
@@ -1011,34 +1002,21 @@ static int r128_cce_dispatch_write_pixel
}
buffer_size = depth->n * sizeof(u32);
- buffer = kmalloc(buffer_size, GFP_KERNEL);
- if (buffer == NULL) {
- kfree(x);
- kfree(y);
- return -ENOMEM;
- }
- if (copy_from_user(buffer, depth->buffer, buffer_size)) {
+ buffer = memdup_user(depth->buffer, buffer_size);
+ if (IS_ERR(buffer)) {
kfree(x);
kfree(y);
- kfree(buffer);
- return -EFAULT;
+ return PTR_ERR(buffer);
}
if (depth->mask) {
mask_size = depth->n * sizeof(u8);
- mask = kmalloc(mask_size, GFP_KERNEL);
- if (mask == NULL) {
- kfree(x);
- kfree(y);
- kfree(buffer);
- return -ENOMEM;
- }
- if (copy_from_user(mask, depth->mask, mask_size)) {
+ mask = memdup_user(depth->mask, mask_size);
+ if (IS_ERR(mask)) {
kfree(x);
kfree(y);
kfree(buffer);
- kfree(mask);
- return -EFAULT;
+ return PTR_ERR(mask);
}
for (i = 0; i < count; i++) {
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
