TO: Frank Praznik <frank.praz...@oh.rr.com>
CC: Jiri Kosina <jkos...@suse.cz>
Hi Frank,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-3.14/sony
head: 61ebca937f2609e66fe6749f8f5df57ff387e2eb
commit: 61ebca937f2609e66fe6749f8f5df57ff387e2eb [18/18] HID: sony: Use colors
for the Dualshock 4 LED names
:::::: branch date: 38 minutes ago
:::::: commit date: 38 minutes ago
drivers/hid/hid-sony.c:882 sony_leds_init() error: buffer overflow 'color_str'
3 <= 3
drivers/hid/hid-sony.c:893 sony_leds_init() error: buffer overflow 'color_str'
3 <= 3
git remote add hid git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
git remote update hid
git checkout 61ebca937f2609e66fe6749f8f5df57ff387e2eb
vim +/color_str +882 drivers/hid/hid-sony.c
f04d5140 Colin Leitner 2013-05-27 876
0a286ef2 Sven Eckelmann 2013-11-19 877 name_sz =
strlen(dev_name(&hdev->dev)) + name_len + 1;
f04d5140 Colin Leitner 2013-05-27 878
60781cf4 Frank Praznik 2014-01-11 879 for (n = 0; n <
drv_data->led_count; n++) {
61ebca93 Frank Praznik 2014-01-20 880
61ebca93 Frank Praznik 2014-01-20 881 if (use_colors)
61ebca93 Frank Praznik 2014-01-20 @882 name_sz =
strlen(dev_name(&hdev->dev)) + strlen(color_str[n]) + 2;
61ebca93 Frank Praznik 2014-01-20 883
40e32ee6 Jiri Kosina 2013-05-28 884 led =
kzalloc(sizeof(struct led_classdev) + name_sz, GFP_KERNEL);
40e32ee6 Jiri Kosina 2013-05-28 885 if (!led) {
40e32ee6 Jiri Kosina 2013-05-28 886 hid_err(hdev,
"Couldn't allocate memory for LED %d\n", n);
8cd5fcda Julia Lawall 2013-12-29 887 ret = -ENOMEM;
40e32ee6 Jiri Kosina 2013-05-28 888 goto error_leds;
40e32ee6 Jiri Kosina 2013-05-28 889 }
f04d5140 Colin Leitner 2013-05-27 890
40e32ee6 Jiri Kosina 2013-05-28 891 name = (void
*)(&led[1]);
61ebca93 Frank Praznik 2014-01-20 892 if (use_colors)
61ebca93 Frank Praznik 2014-01-20 @893 snprintf(name,
name_sz, name_fmt, dev_name(&hdev->dev), color_str[n]);
61ebca93 Frank Praznik 2014-01-20 894 else
61ebca93 Frank Praznik 2014-01-20 895 snprintf(name,
name_sz, name_fmt, dev_name(&hdev->dev), n + 1);
40e32ee6 Jiri Kosina 2013-05-28 896 led->name = name;
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
