[ I can't actually checkout that hash, but probably the bug report is
  correct. ]

Hi Tejun,

FYI, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git 
review-post-kernfs-conversion
head:   f38cf7665be19d00532d12eb5ae057f12cffb924
commit: cd71b9c15a8f80b5ee9daa2aef006b95fe8d5cf8 [24/32] cgroup: convert to 
kernfs

kernel/cgroup.c:1554 cgroup_mount() error: 'root' dereferencing possible 
ERR_PTR()

git remote add cgroup 
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git
git remote update cgroup
git checkout cd71b9c15a8f80b5ee9daa2aef006b95fe8d5cf8
vim +/root +1554 kernel/cgroup.c

cd71b9c1 Tejun Heo   2014-01-28  1538   }
cd71b9c1 Tejun Heo   2014-01-28  1539  
cd71b9c1 Tejun Heo   2014-01-28  1540   ret = cgroup_setup_root(root);
cd71b9c1 Tejun Heo   2014-01-28  1541   if (ret)
cd71b9c1 Tejun Heo   2014-01-28  1542           cgroup_free_root(root);
cd71b9c1 Tejun Heo   2014-01-28  1543  
b6829d78 Tejun Heo   2014-01-28  1544  out_unlock:
e25e2cbb Tejun Heo   2011-12-12  1545   mutex_unlock(&cgroup_mutex);
d685d7ed Tejun Heo   2014-01-28  1546   mutex_unlock(&cgroup_tree_mutex);
b6829d78 Tejun Heo   2014-01-28  1547  
c6d57f33 Paul Menage 2009-09-23  1548   kfree(opts.release_agent);
c6d57f33 Paul Menage 2009-09-23  1549   kfree(opts.name);
b6829d78 Tejun Heo   2014-01-28  1550  
cd71b9c1 Tejun Heo   2014-01-28  1551   if (ret)
b6829d78 Tejun Heo   2014-01-28  1552           return ERR_PTR(ret);
cd71b9c1 Tejun Heo   2014-01-28  1553  
cd71b9c1 Tejun Heo   2014-01-28 @1554   dentry = kernfs_mount(fs_type, flags, 
root->kf_root);
cd71b9c1 Tejun Heo   2014-01-28  1555   if (IS_ERR(dentry))
cd71b9c1 Tejun Heo   2014-01-28  1556           cgroup_put_root(root);
cd71b9c1 Tejun Heo   2014-01-28  1557   return dentry;
cd71b9c1 Tejun Heo   2014-01-28  1558  }
cd71b9c1 Tejun Heo   2014-01-28  1559  
cd71b9c1 Tejun Heo   2014-01-28  1560  static void cgroup_kill_sb(struct 
super_block *sb)
cd71b9c1 Tejun Heo   2014-01-28  1561  {
cd71b9c1 Tejun Heo   2014-01-28  1562   struct kernfs_root *kf_root = 
kernfs_root_from_sb(sb);

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

Reply via email to