Hi Phoebe,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: cb6e926e3f734f0934d3cb5cd7c827158183d367
commit: 4244db1b0b7bc9ab7b67d8c1c38de6cf15bc87a8 [161/168] ieee802154: add
netlink APIs for smartMAC configuration
net/ieee802154/nl-phy.c:440 phy_set_csma_params() warn: impossible condition
'(retries < -1) => (0-255 < (-1))'
git remote add net-next
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
git remote update net-next
git checkout 4244db1b0b7bc9ab7b67d8c1c38de6cf15bc87a8
vim +440 net/ieee802154/nl-phy.c
6ca00197 Phoebe Buckheister 2014-02-17 424
4244db1b Phoebe Buckheister 2014-02-17 425 static int
phy_set_csma_params(struct wpan_phy *phy, struct genl_info *info)
4244db1b Phoebe Buckheister 2014-02-17 426 {
4244db1b Phoebe Buckheister 2014-02-17 427 int rc;
4244db1b Phoebe Buckheister 2014-02-17 428 u8 min_be = phy->min_be;
4244db1b Phoebe Buckheister 2014-02-17 429 u8 max_be = phy->max_be;
4244db1b Phoebe Buckheister 2014-02-17 430 u8 retries = phy->csma_retries;
4244db1b Phoebe Buckheister 2014-02-17 431
4244db1b Phoebe Buckheister 2014-02-17 432 if
(info->attrs[IEEE802154_ATTR_CSMA_RETRIES])
4244db1b Phoebe Buckheister 2014-02-17 433 retries =
nla_get_u8(info->attrs[IEEE802154_ATTR_CSMA_RETRIES]);
4244db1b Phoebe Buckheister 2014-02-17 434 if
(info->attrs[IEEE802154_ATTR_CSMA_MIN_BE])
4244db1b Phoebe Buckheister 2014-02-17 435 min_be =
nla_get_u8(info->attrs[IEEE802154_ATTR_CSMA_MIN_BE]);
4244db1b Phoebe Buckheister 2014-02-17 436 if
(info->attrs[IEEE802154_ATTR_CSMA_MAX_BE])
4244db1b Phoebe Buckheister 2014-02-17 437 max_be =
nla_get_u8(info->attrs[IEEE802154_ATTR_CSMA_MAX_BE]);
4244db1b Phoebe Buckheister 2014-02-17 438
4244db1b Phoebe Buckheister 2014-02-17 439 if (retries > 5 || max_be > 8
|| min_be > max_be ||
4244db1b Phoebe Buckheister 2014-02-17 @440 retries < -1 || retries > 7)
4244db1b Phoebe Buckheister 2014-02-17 441 return -EINVAL;
4244db1b Phoebe Buckheister 2014-02-17 442
4244db1b Phoebe Buckheister 2014-02-17 443 rc = phy->set_csma_params(phy,
min_be, max_be, retries);
4244db1b Phoebe Buckheister 2014-02-17 444 if (rc < 0)
4244db1b Phoebe Buckheister 2014-02-17 445 return rc;
4244db1b Phoebe Buckheister 2014-02-17 446
4244db1b Phoebe Buckheister 2014-02-17 447 phy->min_be = min_be;
4244db1b Phoebe Buckheister 2014-02-17 448 phy->max_be = max_be;
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
