False positive. regards, dan carpenter
On Fri, Feb 28, 2014 at 06:07:03PM +0800, kbuild test robot wrote: > TO: Alex Shi <alex....@linaro.org> > > > Hi Alex, > > FYI, there are new smatch warnings show up in > > tree: https://github.com/alexshi/power-scheduling.git single-balance > head: 243adc32582b0e6acaddf422b9dc0f806c5d04fe > commit: 56510d2e9a058340794c7152dbfb251171eecc7f [8/9] sched/balance: replace > new_idle_balance > :::::: branch date: 72 minutes ago > :::::: commit date: 72 minutes ago > > kernel/sched/fair.c:7235 new_idle_balance() error: potentially dereferencing > uninitialized 'slip'. > > git remote add alexshi https://github.com/alexshi/power-scheduling.git > git remote update alexshi > git checkout 56510d2e9a058340794c7152dbfb251171eecc7f > vim +/slip +7235 kernel/sched/fair.c > > 56510d2e Alex Shi 2014-02-28 7219 slip = &sli; > 56510d2e Alex Shi 2014-02-28 7220 slip->sd = sd; > 56510d2e Alex Shi 2014-02-28 7221 > 56510d2e Alex Shi 2014-02-28 7222 if (cpu == this_cpu) { > 56510d2e Alex Shi 2014-02-28 7223 > insert_cpuload_tree(&slip->unutil, cld); > 56510d2e Alex Shi 2014-02-28 7224 continue; > 56510d2e Alex Shi 2014-02-28 7225 } > 56510d2e Alex Shi 2014-02-28 7226 > 56510d2e Alex Shi 2014-02-28 7227 /* setup under utilization tree > */ > 56510d2e Alex Shi 2014-02-28 7228 if (cld->imb > 0 && > cld->cfs_nr_running > 1) > 56510d2e Alex Shi 2014-02-28 7229 > insert_cpuload_tree(&slip->ovutil, cld); > 56510d2e Alex Shi 2014-02-28 7230 > 56510d2e Alex Shi 2014-02-28 7231 } > 56510d2e Alex Shi 2014-02-28 7232 > 56510d2e Alex Shi 2014-02-28 7233 pre_imb = cpuld[this_cpu].imb; > 56510d2e Alex Shi 2014-02-28 7234 > 56510d2e Alex Shi 2014-02-28 @7235 if (RB_EMPTY_ROOT(&slip->unutil) && > RB_EMPTY_ROOT(&slip->ovutil)) > 56510d2e Alex Shi 2014-02-28 7236 balance_sds(slip, cpus, > &all_balanced); > 56510d2e Alex Shi 2014-02-28 7237 > 56510d2e Alex Shi 2014-02-28 7238 if (single_sd || cpuld[this_cpu].imb > > pre_imb) > 56510d2e Alex Shi 2014-02-28 7239 goto end; > 56510d2e Alex Shi 2014-02-28 7240 goto global; > 56510d2e Alex Shi 2014-02-28 7241 end: > 56510d2e Alex Shi 2014-02-28 7242 rcu_read_unlock(); > 56510d2e Alex Shi 2014-02-28 7243 } > > --- > 0-DAY kernel build testing backend Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation _______________________________________________ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
