Hi Lars-Peter,

FYI, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
head:   0f97ca5cebaede963ccbfc986b7bf5a57c37ee7c
commit: 0f97ca5cebaede963ccbfc986b7bf5a57c37ee7c [3/3] iio:adc: Add Xilinx XADC 
driver

drivers/iio/adc/xilinx-xadc-events.c:252 xadc_write_event_value() warn: 
inconsistent returns mutex:&xadc->mutex: locked (218 [(-22)]) unlocked (206 
[(-22)], 252 [s32min-s32max], 252 [0], 252 [s32min-(-1),1-s32max])

git remote add iio git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
git remote update iio
git checkout 0f97ca5cebaede963ccbfc986b7bf5a57c37ee7c
vim +252 drivers/iio/adc/xilinx-xadc-events.c

0f97ca5c Lars-Peter Clausen 2014-02-17  236                     
xadc->threshold[offset + 4] = 0;
0f97ca5c Lars-Peter Clausen 2014-02-17  237             else
0f97ca5c Lars-Peter Clausen 2014-02-17  238                     
xadc->threshold[offset + 4] = xadc->threshold[offset] -
0f97ca5c Lars-Peter Clausen 2014-02-17  239                                     
xadc->temp_hysteresis;
0f97ca5c Lars-Peter Clausen 2014-02-17  240             ret = 
_xadc_write_adc_reg(xadc, XADC_REG_THRESHOLD(offset + 4),
0f97ca5c Lars-Peter Clausen 2014-02-17  241                     
xadc->threshold[offset + 4]);
0f97ca5c Lars-Peter Clausen 2014-02-17  242             if (ret)
0f97ca5c Lars-Peter Clausen 2014-02-17  243                     goto out_unlock;
0f97ca5c Lars-Peter Clausen 2014-02-17  244     }
0f97ca5c Lars-Peter Clausen 2014-02-17  245  
0f97ca5c Lars-Peter Clausen 2014-02-17  246     if (info == IIO_EV_INFO_VALUE)
0f97ca5c Lars-Peter Clausen 2014-02-17  247             ret = 
_xadc_write_adc_reg(xadc, XADC_REG_THRESHOLD(offset), val);
0f97ca5c Lars-Peter Clausen 2014-02-17  248  
0f97ca5c Lars-Peter Clausen 2014-02-17  249  out_unlock:
0f97ca5c Lars-Peter Clausen 2014-02-17  250     mutex_unlock(&xadc->mutex);
0f97ca5c Lars-Peter Clausen 2014-02-17  251  
0f97ca5c Lars-Peter Clausen 2014-02-17 @252     return ret;
0f97ca5c Lars-Peter Clausen 2014-02-17  253  }

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

Reply via email to