Hi Huang,

FYI, there are coccinelle warnings in

tree:   git://git.infradead.org/users/dedekind/l2-mtd.git master
head:   3192a724e03715a8d33955478307f21249c3196c
commit: 67766cd56820b4d81650806fe01ce7a454c6a314 [32/43] mtd: nand: parse out 
the JEDEC compliant NAND

>> drivers/mtd/nand/nand_base.c:3178:36-63: duplicated argument to && or ||

git remote add l2-mtd git://git.infradead.org/users/dedekind/l2-mtd.git
git remote update l2-mtd
git checkout 67766cd56820b4d81650806fe01ce7a454c6a314
vim +3178 drivers/mtd/nand/nand_base.c

6fb277ba Florian Fainelli 2010-09-01  3162      return 1;
6fb277ba Florian Fainelli 2010-09-01  3163  }
6fb277ba Florian Fainelli 2010-09-01  3164  
6fb277ba Florian Fainelli 2010-09-01  3165  /*
67766cd5 Huang Shijie     2014-02-21  3166   * Check if the NAND chip is JEDEC 
compliant, returns 1 if it is, 0 otherwise.
67766cd5 Huang Shijie     2014-02-21  3167   */
67766cd5 Huang Shijie     2014-02-21  3168  static int 
nand_flash_detect_jedec(struct mtd_info *mtd, struct nand_chip *chip,
67766cd5 Huang Shijie     2014-02-21  3169                                      
int *busw)
67766cd5 Huang Shijie     2014-02-21  3170  {
67766cd5 Huang Shijie     2014-02-21  3171      struct nand_jedec_params *p = 
&chip->jedec_params;
67766cd5 Huang Shijie     2014-02-21  3172      struct jedec_ecc_info *ecc;
67766cd5 Huang Shijie     2014-02-21  3173      int val;
67766cd5 Huang Shijie     2014-02-21  3174      int i, j;
67766cd5 Huang Shijie     2014-02-21  3175  
67766cd5 Huang Shijie     2014-02-21  3176      /* Try JEDEC for unknown chip 
or LP */
67766cd5 Huang Shijie     2014-02-21  3177      chip->cmdfunc(mtd, 
NAND_CMD_READID, 0x40, -1);
67766cd5 Huang Shijie     2014-02-21 @3178      if (chip->read_byte(mtd) != 'J' 
|| chip->read_byte(mtd) != 'E' ||
67766cd5 Huang Shijie     2014-02-21  3179              chip->read_byte(mtd) != 
'D' || chip->read_byte(mtd) != 'E' ||
67766cd5 Huang Shijie     2014-02-21  3180              chip->read_byte(mtd) != 
'C')
67766cd5 Huang Shijie     2014-02-21  3181              return 0;
67766cd5 Huang Shijie     2014-02-21  3182  
67766cd5 Huang Shijie     2014-02-21  3183      chip->cmdfunc(mtd, 
NAND_CMD_PARAM, 0x40, -1);
67766cd5 Huang Shijie     2014-02-21  3184      for (i = 0; i < 3; i++) {
67766cd5 Huang Shijie     2014-02-21  3185              for (j = 0; j < 
sizeof(*p); j++)
67766cd5 Huang Shijie     2014-02-21  3186                      ((uint8_t 
*)p)[j] = chip->read_byte(mtd);

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

Reply via email to