The _PAGE_NX macro is new.  I will add it to
smatch_data/kernel.unconstant_macros to silence this false positive.

regards,
dan carpenter

On Fri, Mar 07, 2014 at 08:02:15AM +0800, kbuild test robot wrote:
> TO: Matt Fleming <matt.flem...@intel.com>
> CC: Ingo Molnar <mi...@kernel.org>
> 
> 
> Hi Ingo,
> 
> FYI, there are new smatch warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master
> head:   3a3dcbe22a11a5a0cc9310d5052be3edf4477e56
> commit: b448eb4a13cd5c469518e14e54fdb9bab66dfdcc [28/29] Merge branch 
> 'x86/efi'
> :::::: branch date: 10 hours ago
> :::::: commit date: 10 hours ago
> 
> arch/x86/platform/efi/efi.c:1084 kexec_enter_virtual_mode() warn: bitwise AND 
> condition is false here
> 
> git remote add tip git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> git remote update tip
> git checkout b448eb4a13cd5c469518e14e54fdb9bab66dfdcc
> vim +1084 arch/x86/platform/efi/efi.c
> 
> fabb37c7 Borislav Petkov 2014-01-18  1068     BUG_ON(!efi.systab);
> fabb37c7 Borislav Petkov 2014-01-18  1069  
> fabb37c7 Borislav Petkov 2014-01-18  1070     efi_sync_low_kernel_mappings();
> fabb37c7 Borislav Petkov 2014-01-18  1071  
> fabb37c7 Borislav Petkov 2014-01-18  1072     /*
> fabb37c7 Borislav Petkov 2014-01-18  1073      * Now that EFI is in virtual 
> mode, update the function
> fabb37c7 Borislav Petkov 2014-01-18  1074      * pointers in the runtime 
> service table to the new virtual addresses.
> fabb37c7 Borislav Petkov 2014-01-18  1075      *
> fabb37c7 Borislav Petkov 2014-01-18  1076      * Call EFI services through 
> wrapper functions.
> fabb37c7 Borislav Petkov 2014-01-18  1077      */
> fabb37c7 Borislav Petkov 2014-01-18  1078     efi.runtime_version = 
> efi_systab.hdr.revision;
> 994448f1 Matt Fleming    2014-03-05  1079  
> 994448f1 Matt Fleming    2014-03-05  1080     native_runtime_setup();
> 994448f1 Matt Fleming    2014-03-05  1081  
> fabb37c7 Borislav Petkov 2014-01-18  1082     efi.set_virtual_address_map = 
> NULL;
> fabb37c7 Borislav Petkov 2014-01-18  1083  
> fabb37c7 Borislav Petkov 2014-01-18 @1084     if (efi_enabled(EFI_OLD_MEMMAP) 
> && (__supported_pte_mask & _PAGE_NX))
> fabb37c7 Borislav Petkov 2014-01-18  1085             
> runtime_code_page_mkexec();
> fabb37c7 Borislav Petkov 2014-01-18  1086  
> fabb37c7 Borislav Petkov 2014-01-18  1087     /* clean DUMMY object */
> fabb37c7 Borislav Petkov 2014-01-18  1088     
> efi.set_variable(efi_dummy_name, &EFI_DUMMY_GUID,
> fabb37c7 Borislav Petkov 2014-01-18  1089                      
> EFI_VARIABLE_NON_VOLATILE |
> fabb37c7 Borislav Petkov 2014-01-18  1090                      
> EFI_VARIABLE_BOOTSERVICE_ACCESS |
> fabb37c7 Borislav Petkov 2014-01-18  1091                      
> EFI_VARIABLE_RUNTIME_ACCESS,
> fabb37c7 Borislav Petkov 2014-01-18  1092                      0, NULL);
> 
> :::::: The code at line 1084 was first introduced by commit
> :::::: fabb37c736f9f688fe3eec98550a5c032a07cfaa x86/efi: Split 
> efi_enter_virtual_mode
> 
> :::::: TO: Borislav Petkov <b...@suse.de>
> :::::: CC: Matt Fleming <matt.flem...@intel.com>
> 
> ---
> 0-DAY kernel build testing backend              Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

Reply via email to