Hi Vytas,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: e86e180b824e00733bd0e499d412a595078f9b51
commit: 4d0e5c076d01d3fb4767a502a9517923fb9a080e [1090/1368] netfilter: ipset:
add markmask for hash:ip,mark data type
net/netfilter/ipset/ip_set_hash_gen.h:1084 hash_ipmark_create() warn:
impossible condition '(markmask > 4294967295) => (0-u32max > u32max)'
git remote add net-next
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
git remote update net-next
git checkout 4d0e5c076d01d3fb4767a502a9517923fb9a080e
vim +1084 net/netfilter/ipset/ip_set_hash_gen.h
1feab10d Jozsef Kadlecsik 2013-04-08 1068 maxelem =
ip_set_get_h32(tb[IPSET_ATTR_MAXELEM]);
1feab10d Jozsef Kadlecsik 2013-04-08 1069
1feab10d Jozsef Kadlecsik 2013-04-08 1070 #ifdef IP_SET_HASH_WITH_NETMASK
1feab10d Jozsef Kadlecsik 2013-04-08 1071 if (tb[IPSET_ATTR_NETMASK]) {
1feab10d Jozsef Kadlecsik 2013-04-08 1072 netmask =
nla_get_u8(tb[IPSET_ATTR_NETMASK]);
1feab10d Jozsef Kadlecsik 2013-04-08 1073
1feab10d Jozsef Kadlecsik 2013-04-08 1074 if ((set->family ==
NFPROTO_IPV4 && netmask > 32) ||
1feab10d Jozsef Kadlecsik 2013-04-08 1075 (set->family ==
NFPROTO_IPV6 && netmask > 128) ||
1feab10d Jozsef Kadlecsik 2013-04-08 1076 netmask == 0)
1feab10d Jozsef Kadlecsik 2013-04-08 1077 return
-IPSET_ERR_INVALID_NETMASK;
1feab10d Jozsef Kadlecsik 2013-04-08 1078 }
1feab10d Jozsef Kadlecsik 2013-04-08 1079 #endif
4d0e5c07 Vytas Dauksa 2013-12-17 1080 #ifdef IP_SET_HASH_WITH_MARKMASK
4d0e5c07 Vytas Dauksa 2013-12-17 1081 if (tb[IPSET_ATTR_MARKMASK]) {
4d0e5c07 Vytas Dauksa 2013-12-17 1082 markmask =
ntohl(nla_get_u32(tb[IPSET_ATTR_MARKMASK]));
4d0e5c07 Vytas Dauksa 2013-12-17 1083
4d0e5c07 Vytas Dauksa 2013-12-17 @1084 if ((markmask >
4294967295u) || markmask == 0)
4d0e5c07 Vytas Dauksa 2013-12-17 1085 return
-IPSET_ERR_INVALID_MARKMASK;
4d0e5c07 Vytas Dauksa 2013-12-17 1086 }
4d0e5c07 Vytas Dauksa 2013-12-17 1087 #endif
1feab10d Jozsef Kadlecsik 2013-04-08 1088
1feab10d Jozsef Kadlecsik 2013-04-08 1089 hsize = sizeof(*h);
1feab10d Jozsef Kadlecsik 2013-04-08 1090 #ifdef IP_SET_HASH_WITH_NETS
1feab10d Jozsef Kadlecsik 2013-04-08 1091 hsize += sizeof(struct
net_prefixes) *
1feab10d Jozsef Kadlecsik 2013-04-08 1092 (set->family ==
NFPROTO_IPV4 ? 32 : 128);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
