On Tue, Mar 18, 2014 at 04:12:25AM +0800, kbuild test robot wrote:
> tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git
> master
> head: dad0d04fa7ba41ce603a01e8e64967650303e9a2
> commit: dad0d04fa7ba41ce603a01e8e64967650303e9a2 [316/316] rsi: Add RS9113
> wireless driver
>
> drivers/net/wireless/rsi/rsi_91x_debugfs.c:296 rsi_init_dbgfs() error:
> potential null dereference 'dev_dbgfs'. (kzalloc returns null)
> drivers/net/wireless/rsi/rsi_91x_debugfs.c:307 rsi_init_dbgfs() error:
> dereferencing freed memory 'dev_dbgfs'
> drivers/net/wireless/rsi/rsi_91x_sdio.c:762 rsi_disconnect() warn: variable
> dereferenced before check 'adapter' (see line 760)
> drivers/net/wireless/rsi/rsi_91x_sdio_ops.c:250 rsi_process_pkt() warn:
> returning -1 instead of -ENOMEM is sloppy
> drivers/net/wireless/rsi/rsi_91x_usb.c:160 rsi_usb_reg_read() error: doing
> dma on the stack (temp_buf)
> drivers/net/wireless/rsi/rsi_91x_usb.c:201 rsi_usb_reg_write() error: doing
> dma on the stack (usb_reg_buf)
> drivers/net/wireless/rsi/rsi_91x_usb.c:289 rsi_usb_write_register_multiple()
> warn: '__min2' 4096 can't fit into 255 'transfer'
>
> vim +/dev_dbgfs +296 drivers/net/wireless/rsi/rsi_91x_debugfs.c
>
> 290
> 291 dev_dbgfs = kzalloc(sizeof(*dev_dbgfs), GFP_KERNEL);
> 292 adapter->dfsentry = dev_dbgfs;
> 293
> 294 snprintf(devdir, sizeof(devdir), "%s",
> 295 wiphy_name(adapter->hw->wiphy));
> > 296 dev_dbgfs->subdir = debugfs_create_dir(devdir, NULL);
> 297
> 298 if (IS_ERR(dev_dbgfs->subdir)) {
Btw, this isn't needed at all. It's also wrong. The error message is
misleading.
debugfs only returns error pointers if the kernel was compiled without
debugfs support. The debugfs_create_file() function accepts NULL
pointers.
There is no need for error handling here by design.
regards,
dan carpenter
> 299 if (dev_dbgfs->subdir == ERR_PTR(-ENODEV))
> 300 rsi_dbg(ERR_ZONE,
> 301 "%s:Debugfs has not been
> mounted\n", __func__);
> 302 else
> 303 rsi_dbg(ERR_ZONE, "debugfs:%s not
> created\n", devdir);
> 304
> 305 adapter->dfsentry = NULL;
> 306 kfree(dev_dbgfs);
> 307 return (int)PTR_ERR(dev_dbgfs->subdir);
> 308 } else {
> 309 for (ii = 0; ii < adapter->num_debugfs_entries;
> ii++) {
> 310 files = &dev_debugfs_files[ii];
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
> _______________________________________________
> kbuild-all mailing list
> kbuild-...@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
