This code has a compile problem. Missing argument to spin_lock_irqsave().
regards,
dan carpenter
On Wed, Apr 09, 2014 at 01:34:15AM +0800, kbuild test robot wrote:
> TO: Jet Chen <jet.c...@intel.com>
>
> tree: git://bee.sh.intel.com/git/tchen37/linux.git timer_debug3
> head: c7c05c6a3c9c585a0d74c052a2908bf159d09f7f
> commit: c7c05c6a3c9c585a0d74c052a2908bf159d09f7f [2/2] Should use
> SOFTIRQ-safe lock in this scenario
> :::::: branch date: 66 minutes ago
> :::::: commit date: 66 minutes ago
>
> kernel/time/clocksource.c:367 clocksource_cpu_notify() warn: statement has no
> effect 3
>
> git remote add tchen git://bee.sh.intel.com/git/tchen37/linux.git
> git remote update tchen
> git checkout c7c05c6a3c9c585a0d74c052a2908bf159d09f7f
> vim +367 kernel/time/clocksource.c
>
> 9fb60336 Thomas Gleixner 2011-09-12 351 * We only clear the
> watchdog_reset_pending, when we did a
> 9fb60336 Thomas Gleixner 2011-09-12 352 * full cycle through all
> clocksources.
> 9fb60336 Thomas Gleixner 2011-09-12 353 */
> 9fb60336 Thomas Gleixner 2011-09-12 354 if (reset_pending)
> 9fb60336 Thomas Gleixner 2011-09-12 355
> atomic_dec(&watchdog_reset_pending);
> 9fb60336 Thomas Gleixner 2011-09-12 356
> 90585a71 Viresh Kumar 2014-04-05 357 queue_timer_on_next_cpu();
> fb63a0eb Martin Schwidefsky 2009-08-14 358 out:
> 5d8b34fd Thomas Gleixner 2007-02-16 359 spin_unlock(&watchdog_lock);
> 5d8b34fd Thomas Gleixner 2007-02-16 360 }
> 0f8e8ef7 Martin Schwidefsky 2009-08-14 361
> 90585a71 Viresh Kumar 2014-04-05 362 static int
> clocksource_cpu_notify(struct notifier_block *self,
> 90585a71 Viresh Kumar 2014-04-05 363
> unsigned long action, void *hcpu)
> 90585a71 Viresh Kumar 2014-04-05 364 {
> 90585a71 Viresh Kumar 2014-04-05 365 long cpu = (long)hcpu;
> 90585a71 Viresh Kumar 2014-04-05 366
> c7c05c6a Jet Chen 2014-04-09 @367
> spin_lock_irqsave(&watchdog_lock);
> 90585a71 Viresh Kumar 2014-04-05 368 if (!watchdog_running)
> 90585a71 Viresh Kumar 2014-04-05 369 goto notify_out;
> 90585a71 Viresh Kumar 2014-04-05 370
> 90585a71 Viresh Kumar 2014-04-05 371 switch (action) {
> 90585a71 Viresh Kumar 2014-04-05 372 case CPU_DEAD:
> 90585a71 Viresh Kumar 2014-04-05 373 case CPU_DEAD_FROZEN:
> 90585a71 Viresh Kumar 2014-04-05 374 if (cpu != timer_cpu)
> 90585a71 Viresh Kumar 2014-04-05 375 break;
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
