Hi Dan, On Thu, Nov 13, 2014 at 12:25:08PM +0300, Dan Carpenter wrote: > I see you have upgraded to the latest and greatest version of Smatch. > :)
Yeah, sorry, it's after I find the smatch worker has been running broken for over a month.. > This one is a false positive, though, sorry for that. I'm not sure how > it gets triggered and I can't reproduce it on my end. > > 2147383647 is a magic number which means approximately the highest valid > pointer on 32 bit systems. I'll keep on messing with it though to see > if I can figure out how this happened. No problem. From now on the smatch I run here should be auto upgraded to your latest git HEAD. :) Thanks, Fengguang > > On Thu, Nov 13, 2014 at 06:15:28AM +0800, kbuild test robot wrote: > > TO: Miklos Szeredi <[email protected]> > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 206c5f60a3d902bc4b56dab2de3e88de5eb06108 > > commit: e9be9d5e76e34872f0c37d72e25bc27fe9e2c54c overlay filesystem > > date: 3 weeks ago > > :::::: branch date: 3 days ago > > :::::: commit date: 3 weeks ago > > > > fs/overlayfs/super.c:367 ovl_lookup() error: passing non negative > > 2147383647 to ERR_PTR > > fs/overlayfs/dir.c:284 ovl_clear_empty() error: passing non negative > > 2147383647 to ERR_PTR > > > > git remote add linus > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > git remote update linus > > git checkout e9be9d5e76e34872f0c37d72e25bc27fe9e2c54c > > vim +367 fs/overlayfs/super.c > > > > e9be9d5e Miklos Szeredi 2014-10-24 351 > > e9be9d5e Miklos Szeredi 2014-10-24 352 oe->__upperdentry = upperdentry; > > e9be9d5e Miklos Szeredi 2014-10-24 353 oe->lowerdentry = lowerdentry; > > e9be9d5e Miklos Szeredi 2014-10-24 354 > > e9be9d5e Miklos Szeredi 2014-10-24 355 dentry->d_fsdata = oe; > > e9be9d5e Miklos Szeredi 2014-10-24 356 d_add(dentry, inode); > > e9be9d5e Miklos Szeredi 2014-10-24 357 > > e9be9d5e Miklos Szeredi 2014-10-24 358 return NULL; > > e9be9d5e Miklos Szeredi 2014-10-24 359 > > e9be9d5e Miklos Szeredi 2014-10-24 360 out_dput: > > e9be9d5e Miklos Szeredi 2014-10-24 361 dput(lowerdentry); > > e9be9d5e Miklos Szeredi 2014-10-24 362 out_dput_upper: > > e9be9d5e Miklos Szeredi 2014-10-24 363 dput(upperdentry); > > e9be9d5e Miklos Szeredi 2014-10-24 364 out_put_dir: > > e9be9d5e Miklos Szeredi 2014-10-24 365 kfree(oe); > > e9be9d5e Miklos Szeredi 2014-10-24 366 out: > > e9be9d5e Miklos Szeredi 2014-10-24 @367 return ERR_PTR(err); > > e9be9d5e Miklos Szeredi 2014-10-24 368 } > > e9be9d5e Miklos Szeredi 2014-10-24 369 > > e9be9d5e Miklos Szeredi 2014-10-24 370 struct file *ovl_path_open(struct > > path *path, int flags) > > e9be9d5e Miklos Szeredi 2014-10-24 371 { > > e9be9d5e Miklos Szeredi 2014-10-24 372 return dentry_open(path, flags, > > current_cred()); > > e9be9d5e Miklos Szeredi 2014-10-24 373 } > > e9be9d5e Miklos Szeredi 2014-10-24 374 > > e9be9d5e Miklos Szeredi 2014-10-24 375 static void ovl_put_super(struct > > super_block *sb) > > > > --- > > 0-DAY kernel test infrastructure Open Source Technology > > Center > > http://lists.01.org/mailman/listinfo/kbuild Intel > > Corporation _______________________________________________ kbuild mailing list [email protected] https://lists.01.org/mailman/listinfo/kbuild
