Hi Julia,

On Thu, Nov 13, 2014 at 11:26:23AM +0100, Julia Lawall wrote:
> Is there any way that we can improve this process?  At the moment, I just
> take the message I get and forward it.

How about always send the patches to public LKML, with you in the CC list?

Thanks,
Fengguang

> ---------- Forwarded message ----------
> Date: Thu, 13 Nov 2014 10:19:13 +0000
> From: Lee Jones <[email protected]>
> To: Julia Lawall <[email protected]>
> Cc: kbuild test robot <[email protected]>,
>     Jacob Pan <[email protected]>, [email protected]
> Subject: Re: [PATCH] iio: adc: fix platform_no_drv_owner.cocci warnings
> 
> On Tue, 11 Nov 2014, Julia Lawall wrote:
> 
> > The owner field is no longer required.  Please consider applying the
> > patch.
> 
> I don't know about Jonathan, but I can't take patches like this.  They
> need to be correctly formatted and sent as a proper patch:
> 
> > On Tue, 11 Nov 2014, kbuild test robot wrote:
> >
> > > TO: Jacob Pan <[email protected]>
> > > CC: Lee Jones <[email protected]>
> > >
> > > drivers/iio/adc/axp288_adc.c:246:3-8: No need to set .owner here. The 
> > > core will do it.
> 
> Incorrect $SUBJECT line for the subsystem.
> 
> > >  Remove .owner field if calls are used which set it automatically
> > >
> > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > >
> > > CC: Jacob Pan <[email protected]>
> 
> Adding a Cc: tag for yourself in a commit log is not good practice.
> 
> > > Signed-off-by: Fengguang Wu <[email protected]>
> > > ---
> > >
> > > Please take the patch only if it's a positive warning. Thanks!
> > >
> > >  axp288_adc.c |    1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > --- a/drivers/iio/adc/axp288_adc.c
> > > +++ b/drivers/iio/adc/axp288_adc.c
> > > @@ -243,7 +243,6 @@ static struct platform_driver axp288_adc
> > >   .remove = axp288_adc_remove,
> > >   .driver = {
> > >           .name = "axp288_adc",
> > > -         .owner = THIS_MODULE,
> > >   },
> > >  };
> > >
> > >
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
kbuild mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild

Reply via email to