[ hwname can't be NULL. The reason for this warning is perhaps you
intended to check something else. But a human reading the code can
figure out the intention... - dan ]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: bbdef57970d5e1887de755474ff1562baa17ef11
commit: 579a05f29611dcef94b6bda21f1d059ab189a263 [2918/6487] mac80211-hwsim:
Provide multicast event for HWSIM_CMD_DEL_RADIO
New smatch warnings:
drivers/net/wireless/mac80211_hwsim.c:2745 hwsim_del_radio_nl() warn: can
'hwname' even be NULL?
Old smatch warnings:
drivers/net/wireless/mac80211_hwsim.c:1974 mac80211_hwsim_get_et_strings()
error: __builtin_memcpy() '*mac80211_hwsim_gstrings_stats' too small (32 vs 288)
git remote add next
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update next
git checkout 579a05f29611dcef94b6bda21f1d059ab189a263
vim +/hwname +2745 drivers/net/wireless/mac80211_hwsim.c
8cdd9e1c3 Ben Greear 2014-10-22 2729 s64 idx = -1;
8cdd9e1c3 Ben Greear 2014-10-22 2730 const char *hwname = NULL;
bc7910989 Johannes Berg 2014-01-06 2731
8cdd9e1c3 Ben Greear 2014-10-22 2732 if
(info->attrs[HWSIM_ATTR_RADIO_ID])
bc7910989 Johannes Berg 2014-01-06 2733 idx =
nla_get_u32(info->attrs[HWSIM_ATTR_RADIO_ID]);
8cdd9e1c3 Ben Greear 2014-10-22 2734 else if
(info->attrs[HWSIM_ATTR_RADIO_NAME])
8cdd9e1c3 Ben Greear 2014-10-22 2735 hwname = (void
*)nla_data(info->attrs[HWSIM_ATTR_RADIO_NAME]);
8cdd9e1c3 Ben Greear 2014-10-22 2736 else
8cdd9e1c3 Ben Greear 2014-10-22 2737 return -EINVAL;
bc7910989 Johannes Berg 2014-01-06 2738
bc7910989 Johannes Berg 2014-01-06 2739 spin_lock_bh(&hwsim_radio_lock);
bc7910989 Johannes Berg 2014-01-06 2740 list_for_each_entry(data,
&hwsim_radios, list) {
8cdd9e1c3 Ben Greear 2014-10-22 2741 if (idx >= 0) {
bc7910989 Johannes Berg 2014-01-06 2742 if (data->idx
!= idx)
bc7910989 Johannes Berg 2014-01-06 2743
continue;
8cdd9e1c3 Ben Greear 2014-10-22 2744 } else {
8cdd9e1c3 Ben Greear 2014-10-22 @2745 if (hwname &&
8cdd9e1c3 Ben Greear 2014-10-22 2746
strcmp(hwname, wiphy_name(data->hw->wiphy)))
8cdd9e1c3 Ben Greear 2014-10-22 2747
continue;
8cdd9e1c3 Ben Greear 2014-10-22 2748 }
8cdd9e1c3 Ben Greear 2014-10-22 2749
bc7910989 Johannes Berg 2014-01-06 2750 list_del(&data->list);
bc7910989 Johannes Berg 2014-01-06 2751
spin_unlock_bh(&hwsim_radio_lock);
579a05f29 Jukka Rissanen 2014-10-31 2752
mac80211_hwsim_del_radio(data, hwname, info);
bc7910989 Johannes Berg 2014-01-06 2753 return 0;
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild
