[ The "||" should be a "|". The other suggestions will go away when you
change that. -dan]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-next
head: 45952ec2b4d2ec9c34c06ef3db2cf8d7b9e91c91
commit: 0d8e282608a60d2babe4d3f766e1de0722d52318 [31/33] vhost/net: larger
header for virtio 1.0
New smatch warnings:
drivers/vhost/net.c:1030 vhost_net_set_features() warn: should this be a
bitwise op?
drivers/vhost/net.c:1030 vhost_net_set_features() warn: should this be a
bitwise op?
drivers/vhost/net.c:1031 vhost_net_set_features() warn: maybe use && instead of
&
Old smatch warnings:
drivers/vhost/net.c:988 vhost_net_set_backend() error: we previously assumed
'sock' could be null (see line 942)
git remote add vhost git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
git remote update vhost
git checkout 0d8e282608a60d2babe4d3f766e1de0722d52318
vim +1030 drivers/vhost/net.c
3a4d5c94 Michael S. Tsirkin 2010-01-14 1024
3a4d5c94 Michael S. Tsirkin 2010-01-14 1025 static int
vhost_net_set_features(struct vhost_net *n, u64 features)
3a4d5c94 Michael S. Tsirkin 2010-01-14 1026 {
8dd014ad David Stevens 2010-07-27 1027 size_t vhost_hlen, sock_hlen,
hdr_len;
3a4d5c94 Michael S. Tsirkin 2010-01-14 1028 int i;
8dd014ad David Stevens 2010-07-27 1029
0d8e2826 Michael S. Tsirkin 2014-10-24 @1030 hdr_len = (features & ((1ULL <<
VIRTIO_NET_F_MRG_RXBUF) ||
0d8e2826 Michael S. Tsirkin 2014-10-24 @1031 (1ULL <<
VIRTIO_F_VERSION_1))) ?
8dd014ad David Stevens 2010-07-27 1032 sizeof(struct
virtio_net_hdr_mrg_rxbuf) :
8dd014ad David Stevens 2010-07-27 1033 sizeof(struct
virtio_net_hdr);
8dd014ad David Stevens 2010-07-27 1034 if (features & (1 <<
VHOST_NET_F_VIRTIO_NET_HDR)) {
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild
