TO: Tejun Heo <[email protected]>
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git
review-cgroup-writeback-wb-prep
head: e310c138a48dcd4f00008264a9ed3b85000ca5f0
commit: 743bfb3e37d5367bbfbf7272667df3f51206c117 [5/10] writeback: move
lingering dirty IO lists transfer from bdi_destroy() to wb_exit()
reproduce:
# apt-get install sparse
git checkout 743bfb3e37d5367bbfbf7272667df3f51206c117
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
:::::: branch date: 45 minutes ago
:::::: commit date: 45 minutes ago
mm/backing-dev.c:44:9: sparse: context imbalance in 'bdi_lock_two' - wrong
count at exit
>> mm/backing-dev.c:478:28: sparse: context imbalance in 'wb_exit' - unexpected
>> unlock
git remote add tj-misc git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git
git remote update tj-misc
git checkout 743bfb3e37d5367bbfbf7272667df3f51206c117
vim +/wb_exit +478 mm/backing-dev.c
743bfb3e Tejun Heo 2014-11-18 462 * dirty inodes on it might
cause other issues. This workaround is
743bfb3e Tejun Heo 2014-11-18 463 * added by ce5f8e779519
("writeback: splice dirty inode entries to
743bfb3e Tejun Heo 2014-11-18 464 * default bdi on
bdi_destroy()") without root-causing the issue.
743bfb3e Tejun Heo 2014-11-18 465 *
743bfb3e Tejun Heo 2014-11-18 466 *
http://lkml.kernel.org/g/[email protected]
743bfb3e Tejun Heo 2014-11-18 467 *
http://thread.gmane.org/gmane.linux.file-systems/35341/focus=35350
743bfb3e Tejun Heo 2014-11-18 468 *
743bfb3e Tejun Heo 2014-11-18 469 * We should probably add
WARN_ON() to find out whether it still
743bfb3e Tejun Heo 2014-11-18 470 * happens and track it down if
so.
743bfb3e Tejun Heo 2014-11-18 471 */
743bfb3e Tejun Heo 2014-11-18 472 if (wb_has_dirty_io(wb)) {
743bfb3e Tejun Heo 2014-11-18 473 struct bdi_writeback
*dst = &default_backing_dev_info.wb;
743bfb3e Tejun Heo 2014-11-18 474
743bfb3e Tejun Heo 2014-11-18 475 bdi_lock_two(wb, dst);
743bfb3e Tejun Heo 2014-11-18 476
list_splice(&wb->b_dirty, &dst->b_dirty);
743bfb3e Tejun Heo 2014-11-18 477 list_splice(&wb->b_io,
&dst->b_io);
743bfb3e Tejun Heo 2014-11-18 @478
list_splice(&wb->b_more_io, &dst->b_more_io);
743bfb3e Tejun Heo 2014-11-18 479
spin_unlock(&wb->list_lock);
743bfb3e Tejun Heo 2014-11-18 480
spin_unlock(&dst->list_lock);
743bfb3e Tejun Heo 2014-11-18 481 }
743bfb3e Tejun Heo 2014-11-18 482
f30d6f56 Tejun Heo 2014-11-18 483 for (i = 0; i <
NR_WB_STAT_ITEMS; i++)
f30d6f56 Tejun Heo 2014-11-18 484
percpu_counter_destroy(&wb->stat[i]);
6467716a Artem Bityutskiy 2010-07-25 485
d993a80b Tejun Heo 2014-11-18 486
fprop_local_destroy_percpu(&wb->completions);
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild
