I have a patch to fix this false positive and, hopefully, I can push it tomorrow.
regards, dan carpenter On Tue, Nov 18, 2014 at 01:41:14PM +0800, kbuild test robot wrote: > TO: Jeff Layton <[email protected]> > > tree: git://git.samba.org/jlayton/linux nfsd-wq > head: 10ba447622aeaa5c48a6c87468e0c9d7c75df595 > commit: 05ffe460928bef643427d8e54f415ac21a725b63 [32/34] sunrpc: set up > workqueue function in svc_xprt > :::::: branch date: 4 hours ago > :::::: commit date: 4 hours ago > > New smatch warnings: > net/sunrpc/svc_xprt.c:155 svc_xprt_init() error: __builtin_memset() 'xprt' > too small (636 vs 676) > > Old smatch warnings: > net/sunrpc/svc_xprt.c:844 svc_recv() error: we previously assumed > 'rqstp->rq_xprt' could be null (see line 801) > > git remote add jlayton git://git.samba.org/jlayton/linux > git remote update jlayton > git checkout 05ffe460928bef643427d8e54f415ac21a725b63 > vim +/xprt +155 net/sunrpc/svc_xprt.c > > e1b3157f Tom Tucker 2007-12-30 139 module_put(owner); > e1b3157f Tom Tucker 2007-12-30 140 } > e1b3157f Tom Tucker 2007-12-30 141 > e1b3157f Tom Tucker 2007-12-30 142 void svc_xprt_put(struct > svc_xprt *xprt) > e1b3157f Tom Tucker 2007-12-30 143 { > e1b3157f Tom Tucker 2007-12-30 144 > kref_put(&xprt->xpt_ref, svc_xprt_free); > e1b3157f Tom Tucker 2007-12-30 145 } > e1b3157f Tom Tucker 2007-12-30 146 > EXPORT_SYMBOL_GPL(svc_xprt_put); > e1b3157f Tom Tucker 2007-12-30 147 > 1d8206b9 Tom Tucker 2007-12-30 148 /* > 1d8206b9 Tom Tucker 2007-12-30 149 * Called by transport drivers > to initialize the transport independent > 1d8206b9 Tom Tucker 2007-12-30 150 * portion of the transport > instance. > 1d8206b9 Tom Tucker 2007-12-30 151 */ > bd4620dd Stanislav Kinsbursky 2011-12-06 152 void svc_xprt_init(struct net > *net, struct svc_xprt_class *xcl, > bd4620dd Stanislav Kinsbursky 2011-12-06 153 struct > svc_xprt *xprt, struct svc_serv *serv) > 1d8206b9 Tom Tucker 2007-12-30 154 { > 1d8206b9 Tom Tucker 2007-12-30 @155 memset(xprt, 0, > sizeof(*xprt)); > 1d8206b9 Tom Tucker 2007-12-30 156 xprt->xpt_class = xcl; > 1d8206b9 Tom Tucker 2007-12-30 157 xprt->xpt_ops = > xcl->xcl_ops; > e1b3157f Tom Tucker 2007-12-30 158 > kref_init(&xprt->xpt_ref); > bb5cf160 Tom Tucker 2007-12-30 159 xprt->xpt_server = serv; > 05ffe460 Jeff Layton 2014-11-17 160 if > (serv->sv_ops->svo_xprt_work) > 05ffe460 Jeff Layton 2014-11-17 161 > INIT_WORK(&xprt->xpt_work, serv->sv_ops->svo_xprt_work); > 7a182083 Tom Tucker 2007-12-30 162 > INIT_LIST_HEAD(&xprt->xpt_list); > 7a182083 Tom Tucker 2007-12-30 163 > INIT_LIST_HEAD(&xprt->xpt_ready); > > :::::: The code at line 155 was first introduced by commit > :::::: 1d8206b97a09e7ff2fbef17d8d1ea008d764eeaa svc: Add an svc transport > class > > :::::: TO: Tom Tucker <[email protected]> > :::::: CC: J. Bruce Fields <[email protected]> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation _______________________________________________ kbuild mailing list [email protected] https://lists.01.org/mailman/listinfo/kbuild
