TO: Thomas Petazzoni <[email protected]>
CC: "Greg Kroah-Hartman" <[email protected]>
CC: Noralf Tronnes <[email protected]>
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 484c60e206b03fe19129dc6ec4582142293cd876
commit: 06d30f0208576f3cf2a0ee2072c1408e392038b4 [369/370] staging: fbtft: add
fbtft_device driver
:::::: branch date: 5 hours ago
:::::: commit date: 31 hours ago
drivers/staging/fbtft/fbtft_device.c:1403 fbtft_device_init() warn: variable
dereferenced before check 'pdata' (see line 1350)
git remote add staging
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout 06d30f0208576f3cf2a0ee2072c1408e392038b4
vim +/pdata +1403 drivers/staging/fbtft/fbtft_device.c
06d30f02 Thomas Petazzoni 2014-12-31 1344 pdata =
p_device->dev.platform_data;
06d30f02 Thomas Petazzoni 2014-12-31 1345 } else {
06d30f02 Thomas Petazzoni 2014-12-31 1346
pr_err(DRVNAME": broken displays array\n");
06d30f02 Thomas Petazzoni 2014-12-31 1347 return
-EINVAL;
06d30f02 Thomas Petazzoni 2014-12-31 1348 }
06d30f02 Thomas Petazzoni 2014-12-31 1349
06d30f02 Thomas Petazzoni 2014-12-31 @1350 pdata->rotate =
rotate;
06d30f02 Thomas Petazzoni 2014-12-31 1351 if (bgr == 0)
06d30f02 Thomas Petazzoni 2014-12-31 1352
pdata->bgr = false;
06d30f02 Thomas Petazzoni 2014-12-31 1353 else if (bgr ==
1)
06d30f02 Thomas Petazzoni 2014-12-31 1354
pdata->bgr = true;
06d30f02 Thomas Petazzoni 2014-12-31 1355 if (startbyte)
06d30f02 Thomas Petazzoni 2014-12-31 1356
pdata->startbyte = startbyte;
06d30f02 Thomas Petazzoni 2014-12-31 1357 if (gamma)
06d30f02 Thomas Petazzoni 2014-12-31 1358
pdata->gamma = gamma;
06d30f02 Thomas Petazzoni 2014-12-31 1359
pdata->display.debug = debug;
06d30f02 Thomas Petazzoni 2014-12-31 1360 if (fps)
06d30f02 Thomas Petazzoni 2014-12-31 1361
pdata->fps = fps;
06d30f02 Thomas Petazzoni 2014-12-31 1362 if (txbuflen)
06d30f02 Thomas Petazzoni 2014-12-31 1363
pdata->txbuflen = txbuflen;
06d30f02 Thomas Petazzoni 2014-12-31 1364 if (init_num)
06d30f02 Thomas Petazzoni 2014-12-31 1365
pdata->display.init_sequence = init;
06d30f02 Thomas Petazzoni 2014-12-31 1366 if (gpio)
06d30f02 Thomas Petazzoni 2014-12-31 1367
pdata->gpios = gpio;
06d30f02 Thomas Petazzoni 2014-12-31 1368 if (custom) {
06d30f02 Thomas Petazzoni 2014-12-31 1369
pdata->display.width = width;
06d30f02 Thomas Petazzoni 2014-12-31 1370
pdata->display.height = height;
06d30f02 Thomas Petazzoni 2014-12-31 1371
pdata->display.buswidth = buswidth;
06d30f02 Thomas Petazzoni 2014-12-31 1372
pdata->display.backlight = 1;
06d30f02 Thomas Petazzoni 2014-12-31 1373 }
06d30f02 Thomas Petazzoni 2014-12-31 1374
06d30f02 Thomas Petazzoni 2014-12-31 1375 if
(displays[i].spi) {
06d30f02 Thomas Petazzoni 2014-12-31 1376 ret =
fbtft_device_spi_device_register(spi);
06d30f02 Thomas Petazzoni 2014-12-31 1377 if
(ret) {
06d30f02 Thomas Petazzoni 2014-12-31 1378
pr_err(DRVNAME \
06d30f02 Thomas Petazzoni 2014-12-31 1379
": failed to register SPI device\n");
06d30f02 Thomas Petazzoni 2014-12-31 1380
return ret;
06d30f02 Thomas Petazzoni 2014-12-31 1381 }
06d30f02 Thomas Petazzoni 2014-12-31 1382 found =
true;
06d30f02 Thomas Petazzoni 2014-12-31 1383 break;
06d30f02 Thomas Petazzoni 2014-12-31 1384 } else {
06d30f02 Thomas Petazzoni 2014-12-31 1385 ret =
platform_device_register(p_device);
06d30f02 Thomas Petazzoni 2014-12-31 1386 if (ret
< 0) {
06d30f02 Thomas Petazzoni 2014-12-31 1387
pr_err(DRVNAME \
06d30f02 Thomas Petazzoni 2014-12-31 1388
": platform_device_register() returned %d\n",
06d30f02 Thomas Petazzoni 2014-12-31 1389
ret);
06d30f02 Thomas Petazzoni 2014-12-31 1390
return ret;
06d30f02 Thomas Petazzoni 2014-12-31 1391 }
06d30f02 Thomas Petazzoni 2014-12-31 1392 found =
true;
06d30f02 Thomas Petazzoni 2014-12-31 1393 break;
06d30f02 Thomas Petazzoni 2014-12-31 1394 }
06d30f02 Thomas Petazzoni 2014-12-31 1395 }
06d30f02 Thomas Petazzoni 2014-12-31 1396 }
06d30f02 Thomas Petazzoni 2014-12-31 1397
06d30f02 Thomas Petazzoni 2014-12-31 1398 if (!found) {
06d30f02 Thomas Petazzoni 2014-12-31 1399 pr_err(DRVNAME":
display not supported: '%s'\n", name);
06d30f02 Thomas Petazzoni 2014-12-31 1400 return -EINVAL;
06d30f02 Thomas Petazzoni 2014-12-31 1401 }
06d30f02 Thomas Petazzoni 2014-12-31 1402
06d30f02 Thomas Petazzoni 2014-12-31 @1403 if (verbose && pdata &&
pdata->gpios) {
06d30f02 Thomas Petazzoni 2014-12-31 1404 gpio = pdata->gpios;
06d30f02 Thomas Petazzoni 2014-12-31 1405 pr_info(DRVNAME":
GPIOS used by '%s':\n", name);
06d30f02 Thomas Petazzoni 2014-12-31 1406 found = false;
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild
