Thanks Dan, we will update our smatch code to latest and adopt in build cluster as soon as possible.
> -----Original Message----- > From: kbuild [mailto:kbuild-boun...@lists.01.org] On Behalf Of Dan Carpenter > Sent: Thursday, March 21, 2019 2:11 PM > To: lkp <l...@intel.com> > Cc: kbu...@01.org > Subject: Re: [kbuild] [Intel-gfx] [PATCH 09/18] drm/i915: Create/destroy VM > (ppGTT) for use with contexts > > I'm sorry, we seem to be getting a bunch of these false positives. I > pushed a bunch of changes on Monday which hopefully fix it. > > regards, > dan carpenter > > > On Thu, Mar 21, 2019 at 01:42:16PM +0800, kbuild test robot wrote: > > CC: kbuild-...@01.org > > In-Reply-To: <20190319115742.21844-9-ch...@chris-wilson.co.uk> > > References: <20190319115742.21844-9-ch...@chris-wilson.co.uk> > > TO: Chris Wilson <ch...@chris-wilson.co.uk> > > CC: intel-...@lists.freedesktop.org > > CC: > > > > Hi Chris, > > > > Thank you for the patch! Perhaps something to improve: > > > > [auto build test WARNING on drm-intel/for-linux-next] > > [also build test WARNING on next-20190320] > > [cannot apply to v5.1-rc1] > > [if your patch is applied to the wrong git tree, please drop us a note to > > help > improve the system] > > > > url: > > https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-selftests- > Provide-stub-reset-functions/20190319-215821 > > base: git://anongit.freedesktop.org/drm-intel for-linux-next > > :::::: branch date: 2 days ago > > :::::: commit date: 2 days ago > > > > New smatch warnings: > > drivers/gpu/drm/i915/i915_gem_context.c:721 i915_gem_vm_create_ioctl() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:1006 emit_ppgtt_update() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:611 igt_shared_ctx_exec() > warn: passing zero to 'PTR_ERR' > > > > Old smatch warnings: > > drivers/gpu/drm/i915/i915_gem_context.c:424 i915_gem_create_context() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:427 i915_gem_create_context() warn: > passing zero to 'ERR_CAST' > > drivers/gpu/drm/i915/i915_gem_context.c:552 i915_gem_contexts_init() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:664 i915_gem_context_open() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:686 i915_gem_context_open() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:869 context_barrier_task() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:913 > i915_gem_switch_to_kernel_context() warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:1020 emit_ppgtt_update() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:1144 i915_gem_context_create_ioctl() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:1159 i915_gem_context_create_ioctl() > warn: inconsistent returns 'mutex:&dev->struct_mutex'. > > Locked on: line 1120 > > Unlocked on: line 1144 > > drivers/gpu/drm/i915/i915_gem_context.c:1217 get_sseu() warn: passing zero > to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:1306 gen8_emit_rpcs_config() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:1346 gen8_modify_rpcs() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/i915_gem_context.c:1400 > __i915_gem_context_reconfigure_sseu() warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:67 live_nop_switch() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:95 live_nop_switch() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:125 live_nop_switch() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:232 gpu_fill_dw() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:276 gpu_fill() warn: > > passing > zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:299 gpu_fill() warn: > > passing > zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:305 gpu_fill() warn: > > passing > zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:515 igt_ctx_exec() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:532 igt_ctx_exec() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:539 igt_ctx_exec() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:617 igt_shared_ctx_exec() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:648 igt_shared_ctx_exec() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:657 igt_shared_ctx_exec() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:740 rpcs_query_batch() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:770 emit_rpcs_query() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:782 emit_rpcs_query() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:788 emit_rpcs_query() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:857 __sseu_prepare() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1019 __sseu_test() warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1083 __igt_ctx_sseu() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1092 __igt_ctx_sseu() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1192 igt_ctx_readonly() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1202 igt_ctx_readonly() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1227 igt_ctx_readonly() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1336 write_to_scratch() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1350 write_to_scratch() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1431 read_from_scratch() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1445 read_from_scratch() > warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1513 igt_vm_isolation() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1523 igt_vm_isolation() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1529 igt_vm_isolation() > > warn: > passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1630 > __igt_switch_to_kernel_context() warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1693 > igt_switch_to_kernel_context() warn: passing zero to 'PTR_ERR' > > drivers/gpu/drm/i915/selftests/i915_gem_context.c:1745 > > mock_context_barrier() > warn: passing zero to 'PTR_ERR' > > > > # https://github.com/0day- > ci/linux/commit/1308d4b7e247f3a0de07ac28ed1d5ae119e6b0b2 > > git remote add linux-review https://github.com/0day-ci/linux > > git remote update linux-review > > git checkout 1308d4b7e247f3a0de07ac28ed1d5ae119e6b0b2 > > vim +/PTR_ERR +721 drivers/gpu/drm/i915/i915_gem_context.c > > > > 1308d4b7 Chris Wilson 2019-03-19 703 > > 1308d4b7 Chris Wilson 2019-03-19 704 int i915_gem_vm_create_ioctl(struct > drm_device *dev, void *data, > > 1308d4b7 Chris Wilson 2019-03-19 705 struct > > drm_file > *file) > > 1308d4b7 Chris Wilson 2019-03-19 706 { > > 1308d4b7 Chris Wilson 2019-03-19 707 struct drm_i915_private *i915 = > to_i915(dev); > > 1308d4b7 Chris Wilson 2019-03-19 708 struct drm_i915_gem_vm_control > *args = data; > > 1308d4b7 Chris Wilson 2019-03-19 709 struct drm_i915_file_private > *file_priv = file->driver_priv; > > 1308d4b7 Chris Wilson 2019-03-19 710 struct i915_hw_ppgtt *ppgtt; > > 1308d4b7 Chris Wilson 2019-03-19 711 int err; > > 1308d4b7 Chris Wilson 2019-03-19 712 > > 1308d4b7 Chris Wilson 2019-03-19 713 if (!HAS_FULL_PPGTT(i915)) > > 1308d4b7 Chris Wilson 2019-03-19 714 return -ENODEV; > > 1308d4b7 Chris Wilson 2019-03-19 715 > > 1308d4b7 Chris Wilson 2019-03-19 716 if (args->flags) > > 1308d4b7 Chris Wilson 2019-03-19 717 return -EINVAL; > > 1308d4b7 Chris Wilson 2019-03-19 718 > > 1308d4b7 Chris Wilson 2019-03-19 719 ppgtt = i915_ppgtt_create(i915); > > 1308d4b7 Chris Wilson 2019-03-19 720 if (IS_ERR(ppgtt)) > > 1308d4b7 Chris Wilson 2019-03-19 @721 return PTR_ERR(ppgtt); > > 1308d4b7 Chris Wilson 2019-03-19 722 > > 1308d4b7 Chris Wilson 2019-03-19 723 ppgtt->vm.file = file_priv; > > 1308d4b7 Chris Wilson 2019-03-19 724 > > 1308d4b7 Chris Wilson 2019-03-19 725 if (args->extensions) { > > 1308d4b7 Chris Wilson 2019-03-19 726 err = > i915_user_extensions(u64_to_user_ptr(args->extensions), > > 1308d4b7 Chris Wilson 2019-03-19 727 > NULL, 0, > > 1308d4b7 Chris Wilson 2019-03-19 728 > ppgtt); > > 1308d4b7 Chris Wilson 2019-03-19 729 if (err) > > 1308d4b7 Chris Wilson 2019-03-19 730 goto err_put; > > 1308d4b7 Chris Wilson 2019-03-19 731 } > > 1308d4b7 Chris Wilson 2019-03-19 732 > > 1308d4b7 Chris Wilson 2019-03-19 733 err = > mutex_lock_interruptible(&file_priv->vm_idr_lock); > > 1308d4b7 Chris Wilson 2019-03-19 734 if (err) > > 1308d4b7 Chris Wilson 2019-03-19 735 goto err_put; > > 1308d4b7 Chris Wilson 2019-03-19 736 > > 1308d4b7 Chris Wilson 2019-03-19 737 err = > > idr_alloc(&file_priv->vm_idr, > ppgtt, 0, 0, GFP_KERNEL); > > 1308d4b7 Chris Wilson 2019-03-19 738 if (err < 0) > > 1308d4b7 Chris Wilson 2019-03-19 739 goto err_unlock; > > 1308d4b7 Chris Wilson 2019-03-19 740 > > 1308d4b7 Chris Wilson 2019-03-19 741 GEM_BUG_ON(err == 0); /* > reserved for default/unassigned ppgtt */ > > 1308d4b7 Chris Wilson 2019-03-19 742 ppgtt->user_handle = err; > > 1308d4b7 Chris Wilson 2019-03-19 743 > > 1308d4b7 Chris Wilson 2019-03-19 744 mutex_unlock(&file_priv- > >vm_idr_lock); > > 1308d4b7 Chris Wilson 2019-03-19 745 > > 1308d4b7 Chris Wilson 2019-03-19 746 args->vm_id = err; > > 1308d4b7 Chris Wilson 2019-03-19 747 return 0; > > 1308d4b7 Chris Wilson 2019-03-19 748 > > 1308d4b7 Chris Wilson 2019-03-19 749 err_unlock: > > 1308d4b7 Chris Wilson 2019-03-19 750 mutex_unlock(&file_priv- > >vm_idr_lock); > > 1308d4b7 Chris Wilson 2019-03-19 751 err_put: > > 1308d4b7 Chris Wilson 2019-03-19 752 i915_ppgtt_put(ppgtt); > > 1308d4b7 Chris Wilson 2019-03-19 753 return err; > > 1308d4b7 Chris Wilson 2019-03-19 754 } > > 1308d4b7 Chris Wilson 2019-03-19 755 > > > > --- > > 0-DAY kernel test infrastructure Open Source Technology > > Center > > https://lists.01.org/pipermail/kbuild-all Intel > > Corporation > _______________________________________________ > kbuild mailing list > kbuild@lists.01.org > https://lists.01.org/mailman/listinfo/kbuild _______________________________________________ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
