tree: https://github.com/plbossart/sound fix/soundwire-dev3 head: be20d4ffe90df065bc8e9a5b16bc6a8c3283e7e1 commit: cc3a9488a922dcb0e15e0e316c3bf11f487ec565 [58/64] ASoC: codecs: add rt700 support
If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> New smatch warnings: sound/soc/codecs/rt700.c:1511 rt700_io_init() error: uninitialized symbol 'ret'. # https://github.com/plbossart/sound/commit/cc3a9488a922dcb0e15e0e316c3bf11f487ec565 git remote add plbossart-sound https://github.com/plbossart/sound git remote update plbossart-sound git checkout cc3a9488a922dcb0e15e0e316c3bf11f487ec565 vim +/ret +1511 sound/soc/codecs/rt700.c cc3a9488 Shuming Fan 2018-04-18 1454 int rt700_io_init(struct device *dev, struct sdw_slave *slave) cc3a9488 Shuming Fan 2018-04-18 1455 { cc3a9488 Shuming Fan 2018-04-18 1456 struct rt700_priv *rt700 = dev_get_drvdata(dev); cc3a9488 Shuming Fan 2018-04-18 1457 int ret; cc3a9488 Shuming Fan 2018-04-18 1458 cc3a9488 Shuming Fan 2018-04-18 1459 if (rt700->hw_init) cc3a9488 Shuming Fan 2018-04-18 1460 return 0; cc3a9488 Shuming Fan 2018-04-18 1461 cc3a9488 Shuming Fan 2018-04-18 1462 /* Enable Runtime PM */ cc3a9488 Shuming Fan 2018-04-18 1463 pm_runtime_set_autosuspend_delay(&slave->dev, 3000); cc3a9488 Shuming Fan 2018-04-18 1464 pm_runtime_use_autosuspend(&slave->dev); cc3a9488 Shuming Fan 2018-04-18 1465 pm_runtime_enable(&slave->dev); cc3a9488 Shuming Fan 2018-04-18 1466 cc3a9488 Shuming Fan 2018-04-18 1467 /* Set Pin Widget */ cc3a9488 Shuming Fan 2018-04-18 1468 regmap_write(rt700->regmap, RT700_SET_PIN_HP, 0x40); cc3a9488 Shuming Fan 2018-04-18 1469 regmap_write(rt700->regmap, RT700_SET_PIN_SPK, 0x40); cc3a9488 Shuming Fan 2018-04-18 1470 regmap_write(rt700->regmap, RT700_SET_EAPD_SPK, RT700_EAPD_HIGH); cc3a9488 Shuming Fan 2018-04-18 1471 regmap_write(rt700->regmap, RT700_SET_PIN_DMIC1, 0x20); cc3a9488 Shuming Fan 2018-04-18 1472 regmap_write(rt700->regmap, RT700_SET_PIN_DMIC2, 0x20); cc3a9488 Shuming Fan 2018-04-18 1473 regmap_write(rt700->regmap, RT700_SET_PIN_MIC2, 0x20); cc3a9488 Shuming Fan 2018-04-18 1474 cc3a9488 Shuming Fan 2018-04-18 1475 /* Set Configuration Default */ cc3a9488 Shuming Fan 2018-04-18 1476 regmap_write(rt700->regmap, 0x4f12, 0x91); cc3a9488 Shuming Fan 2018-04-18 1477 regmap_write(rt700->regmap, 0x4e12, 0xd6); cc3a9488 Shuming Fan 2018-04-18 1478 regmap_write(rt700->regmap, 0x4d12, 0x11); cc3a9488 Shuming Fan 2018-04-18 1479 regmap_write(rt700->regmap, 0x4c12, 0x20); cc3a9488 Shuming Fan 2018-04-18 1480 regmap_write(rt700->regmap, 0x4f13, 0x91); cc3a9488 Shuming Fan 2018-04-18 1481 regmap_write(rt700->regmap, 0x4e13, 0xd6); cc3a9488 Shuming Fan 2018-04-18 1482 regmap_write(rt700->regmap, 0x4d13, 0x11); cc3a9488 Shuming Fan 2018-04-18 1483 regmap_write(rt700->regmap, 0x4c13, 0x21); cc3a9488 Shuming Fan 2018-04-18 1484 cc3a9488 Shuming Fan 2018-04-18 1485 regmap_write(rt700->regmap, 0x4f19, 0x02); cc3a9488 Shuming Fan 2018-04-18 1486 regmap_write(rt700->regmap, 0x4e19, 0xa1); cc3a9488 Shuming Fan 2018-04-18 1487 regmap_write(rt700->regmap, 0x4d19, 0x90); cc3a9488 Shuming Fan 2018-04-18 1488 regmap_write(rt700->regmap, 0x4c19, 0x80); cc3a9488 Shuming Fan 2018-04-18 1489 cc3a9488 Shuming Fan 2018-04-18 1490 /* Enable Line2 */ cc3a9488 Shuming Fan 2018-04-18 1491 regmap_write(rt700->regmap, 0x371b, 0x40); cc3a9488 Shuming Fan 2018-04-18 1492 regmap_write(rt700->regmap, 0x731b, 0xb0); cc3a9488 Shuming Fan 2018-04-18 1493 regmap_write(rt700->regmap, 0x839b, 0x00); cc3a9488 Shuming Fan 2018-04-18 1494 cc3a9488 Shuming Fan 2018-04-18 1495 /* Set index */ cc3a9488 Shuming Fan 2018-04-18 1496 rt700_index_write(rt700->regmap, 0x4a, 0x201b); cc3a9488 Shuming Fan 2018-04-18 1497 cc3a9488 Shuming Fan 2018-04-18 1498 /* Enable Jack Detection */ cc3a9488 Shuming Fan 2018-04-18 1499 regmap_write(rt700->regmap, RT700_SET_MIC2_UNSOLICITED_ENABLE, 0x82); cc3a9488 Shuming Fan 2018-04-18 1500 regmap_write(rt700->regmap, RT700_SET_HP_UNSOLICITED_ENABLE, 0x81); cc3a9488 Shuming Fan 2018-04-18 1501 rt700_index_write(rt700->regmap, 0x10, 0x2420); cc3a9488 Shuming Fan 2018-04-18 1502 rt700_index_write(rt700->regmap, 0x19, 0x2e11); cc3a9488 Shuming Fan 2018-04-18 1503 cc3a9488 Shuming Fan 2018-04-18 1504 /* Finish Initial Settings, set power to D3 */ cc3a9488 Shuming Fan 2018-04-18 1505 regmap_write(rt700->regmap, RT700_SET_AUDIO_POWER_STATE, AC_PWRST_D3); cc3a9488 Shuming Fan 2018-04-18 1506 cc3a9488 Shuming Fan 2018-04-18 1507 pm_runtime_put_sync_autosuspend(&slave->dev); cc3a9488 Shuming Fan 2018-04-18 1508 cc3a9488 Shuming Fan 2018-04-18 1509 /* Mark Slave initialization complete */ cc3a9488 Shuming Fan 2018-04-18 1510 rt700->hw_init = true; cc3a9488 Shuming Fan 2018-04-18 @1511 return ret; Uninitialized. It should just be "return 0; GCC probably actually does initialize it to zero if you compile with -02 as the kernel does. So that's why it doesn't warn and isn't detected int testing. Someone filed a GCC bug for this a few years back. cc3a9488 Shuming Fan 2018-04-18 1512 } cc3a9488 Shuming Fan 2018-04-18 1513 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation _______________________________________________ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
