On Thu, Nov 21, 2019 at 04:06:10PM +0000, Igor Mitsyanko wrote: > Thanks Dan! > > @Sergey I think we do not need !skb check at all in this function, > agree? I assume if we remove "if (ret && skb)" it will make smatch happy? >
Yes. Smatch only cares about consistent checking. Or it will accept inconsistent NULL checks so long as it is convinced that the pointer can't be NULL. regards, dan carpenter _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
