CC: [email protected] TO: Sathish Narasimman <[email protected]> CC: Johan Hedberg <[email protected]> CC: Chethan T N <[email protected]> CC: "Hsin-Yu Chao" <[email protected]> CC: Amit K Bag <[email protected]> CC: Marcel Holtmann <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 5798bd75ab137611da5c4cb11b6795d14cb60ba2 commit: baac6276c0a9f36f1fe1f00590ef00d2ba5ba626 [13120/13818] Bluetooth: btusb: handle mSBC audio over USB Endpoints :::::: branch date: 20 hours ago :::::: commit date: 3 days ago If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/bluetooth/btusb.c:1665 btusb_work() error: we previously assumed 'data->isoc' could be null (see line 1642) Old smatch warnings: drivers/bluetooth/btusb.c:2026 btusb_setup_intel() warn: inconsistent indenting # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=baac6276c0a9f36f1fe1f00590ef00d2ba5ba626 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git remote update linux-next git checkout baac6276c0a9f36f1fe1f00590ef00d2ba5ba626 vim +1665 drivers/bluetooth/btusb.c baac6276c0a9f3 Sathish Narasimman 2020-04-03 1632 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1633 static void btusb_work(struct work_struct *work) baac6276c0a9f3 Sathish Narasimman 2020-04-03 1634 { baac6276c0a9f3 Sathish Narasimman 2020-04-03 1635 struct btusb_data *data = container_of(work, struct btusb_data, work); baac6276c0a9f3 Sathish Narasimman 2020-04-03 1636 struct hci_dev *hdev = data->hdev; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1637 int new_alts = 0; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1638 int err; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1639 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1640 if (data->sco_num > 0) { baac6276c0a9f3 Sathish Narasimman 2020-04-03 1641 if (!test_bit(BTUSB_DID_ISO_RESUME, &data->flags)) { baac6276c0a9f3 Sathish Narasimman 2020-04-03 @1642 err = usb_autopm_get_interface(data->isoc ? data->isoc : data->intf); baac6276c0a9f3 Sathish Narasimman 2020-04-03 1643 if (err < 0) { baac6276c0a9f3 Sathish Narasimman 2020-04-03 1644 clear_bit(BTUSB_ISOC_RUNNING, &data->flags); baac6276c0a9f3 Sathish Narasimman 2020-04-03 1645 usb_kill_anchored_urbs(&data->isoc_anchor); baac6276c0a9f3 Sathish Narasimman 2020-04-03 1646 return; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1647 } baac6276c0a9f3 Sathish Narasimman 2020-04-03 1648 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1649 set_bit(BTUSB_DID_ISO_RESUME, &data->flags); baac6276c0a9f3 Sathish Narasimman 2020-04-03 1650 } baac6276c0a9f3 Sathish Narasimman 2020-04-03 1651 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1652 if (data->air_mode == HCI_NOTIFY_ENABLE_SCO_CVSD) { baac6276c0a9f3 Sathish Narasimman 2020-04-03 1653 if (hdev->voice_setting & 0x0020) { baac6276c0a9f3 Sathish Narasimman 2020-04-03 1654 static const int alts[3] = { 2, 4, 5 }; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1655 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1656 new_alts = alts[data->sco_num - 1]; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1657 } else { baac6276c0a9f3 Sathish Narasimman 2020-04-03 1658 new_alts = data->sco_num; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1659 } baac6276c0a9f3 Sathish Narasimman 2020-04-03 1660 } else if (data->air_mode == HCI_NOTIFY_ENABLE_SCO_TRANSP) { baac6276c0a9f3 Sathish Narasimman 2020-04-03 1661 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1662 data->usb_alt6_packet_flow = true; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1663 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1664 /* Check if Alt 6 is supported for Transparent audio */ baac6276c0a9f3 Sathish Narasimman 2020-04-03 @1665 if (btusb_find_altsetting(data, 6)) baac6276c0a9f3 Sathish Narasimman 2020-04-03 1666 new_alts = 6; baac6276c0a9f3 Sathish Narasimman 2020-04-03 1667 else baac6276c0a9f3 Sathish Narasimman 2020-04-03 1668 bt_dev_err(hdev, "Device does not support ALT setting 6"); baac6276c0a9f3 Sathish Narasimman 2020-04-03 1669 } baac6276c0a9f3 Sathish Narasimman 2020-04-03 1670 baac6276c0a9f3 Sathish Narasimman 2020-04-03 1671 if (btusb_switch_alt_setting(hdev, new_alts) < 0) baac6276c0a9f3 Sathish Narasimman 2020-04-03 1672 bt_dev_err(hdev, "set USB alt:(%d) failed!", new_alts); 9bfa35fe422c74 Marcel Holtmann 2008-08-18 1673 } else { 9bfa35fe422c74 Marcel Holtmann 2008-08-18 1674 clear_bit(BTUSB_ISOC_RUNNING, &data->flags); 9bfa35fe422c74 Marcel Holtmann 2008-08-18 1675 usb_kill_anchored_urbs(&data->isoc_anchor); 9bfa35fe422c74 Marcel Holtmann 2008-08-18 1676 9bfa35fe422c74 Marcel Holtmann 2008-08-18 1677 __set_isoc_interface(hdev, 0); 08b8b6c454092a Gustavo Padovan 2010-07-16 1678 if (test_and_clear_bit(BTUSB_DID_ISO_RESUME, &data->flags)) 8efdd0cdc54f3b Oliver Neukum 2011-02-11 1679 usb_autopm_put_interface(data->isoc ? data->isoc : data->intf); 7bee549e197c9c Oliver Neukum 2009-08-24 1680 } 7bee549e197c9c Oliver Neukum 2009-08-24 1681 } 7bee549e197c9c Oliver Neukum 2009-08-24 1682 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
