CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: James Smart <[email protected]> CC: [email protected] CC: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], James Smart <[email protected]>, Ram Vegesna <[email protected]>
From: kbuild test robot <[email protected]> drivers/scsi/elx/efct/efct_lio.c:265:22-29: WARNING: kzalloc should be used for filp -> private_data, instead of kmalloc/memset drivers/scsi/elx/efct/efct_lio.c:303:22-29: WARNING: kzalloc should be used for filp -> private_data, instead of kmalloc/memset drivers/scsi/elx/efct/efct_lio.c:1462:11-18: WARNING: kzalloc should be used for wq_data, instead of kmalloc/memset Use zeroing allocator rather than allocator followed by memset with 0 This considers some simple cases that are common and easy to validate Note in particular that there are no ...s in the rule, so all of the matched code has to be contiguous Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci CC: James Smart <[email protected]> Signed-off-by: kbuild test robot <[email protected]> --- url: https://github.com/0day-ci/linux/commits/James-Smart/efct-Broadcom-Emulex-FC-Target-driver/20200412-114125 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago efct_lio.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/drivers/scsi/elx/efct/efct_lio.c +++ b/drivers/scsi/elx/efct/efct_lio.c @@ -262,11 +262,10 @@ static int efct_debugfs_session_open(str return EFC_SUCCESS; } - filp->private_data = kmalloc(size, GFP_KERNEL); + filp->private_data = kzalloc(size, GFP_KERNEL); if (!filp->private_data) return -ENOMEM; - memset(filp->private_data, 0, size); efct_lio_tgt_session_data(sport->efct, sport->wwpn, filp->private_data, size); return EFC_SUCCESS; @@ -300,11 +299,10 @@ static int efct_npiv_debugfs_session_ope return EFC_SUCCESS; } - filp->private_data = kmalloc(size, GFP_KERNEL); + filp->private_data = kzalloc(size, GFP_KERNEL); if (!filp->private_data) return -ENOMEM; - memset(filp->private_data, 0, size); efct_lio_tgt_session_data(sport->efct, sport->npiv_wwpn, filp->private_data, size); return EFC_SUCCESS; @@ -1459,11 +1457,10 @@ int efct_scsi_del_initiator(struct efc * if (reason == EFCT_SCSI_INITIATOR_MISSING) return EFCT_SCSI_CALL_COMPLETE; - wq_data = kmalloc(sizeof(*wq_data), GFP_ATOMIC); + wq_data = kzalloc(sizeof(*wq_data), GFP_ATOMIC); if (!wq_data) return EFCT_SCSI_CALL_COMPLETE; - memset(wq_data, 0, sizeof(*wq_data)); wq_data->ptr = node; wq_data->efct = efct; INIT_WORK(&wq_data->work, efct_lio_remove_session); _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
