CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Alexandre Belloni <[email protected]> TO: Jonathan Cameron <[email protected]> CC: Hartmut Knaack <[email protected]> CC: "Lars-Peter Clausen" <[email protected]> CC: "Peter Meerwald-Stadler" <[email protected]> CC: Gregory CLEMENT <[email protected]> CC: [email protected] CC: [email protected] CC: Alexandre Belloni <[email protected]>
Hi Alexandre, I love your patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on v5.7-rc1 next-20200415] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Alexandre-Belloni/iio-adc-ti-ads8344-improve-the-driver/20200416-073357 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg :::::: branch date: 8 hours ago :::::: commit date: 8 hours ago If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <[email protected]> cppcheck warnings: (new ones prefixed by >>) >> drivers/iio/adc/ti-ads8344.c:96:36: warning: The code contains unhandled >> character(s) (character code=194). Neither unicode nor extended ascii is >> supported. [syntaxError] return buf[0] << 9 | buf[1] << 1 | buf[2] >> 7; ^ # https://github.com/0day-ci/linux/commit/f4710fdd10c9cf84bd09d8b295a435b371800bd0 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout f4710fdd10c9cf84bd09d8b295a435b371800bd0 vim +96 drivers/iio/adc/ti-ads8344.c 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 72 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 73 static int ads8344_adc_conversion(struct ads8344 *adc, int channel, 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 74 bool differential) 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 75 { 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 76 struct spi_device *spi = adc->spi; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 77 int ret; f4710fdd10c9cf Alexandre Belloni 2020-04-15 78 u8 buf[3]; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 79 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 80 adc->tx_buf = ADS8344_START; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 81 if (!differential) 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 82 adc->tx_buf |= ADS8344_SINGLE_END; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 83 adc->tx_buf |= ADS8344_CHANNEL(channel); 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 84 adc->tx_buf |= ADS8344_CLOCK_INTERNAL; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 85 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 86 ret = spi_write(spi, &adc->tx_buf, 1); 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 87 if (ret) 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 88 return ret; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 89 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 90 udelay(9); 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 91 f4710fdd10c9cf Alexandre Belloni 2020-04-15 92 ret = spi_read(spi, buf, sizeof(buf)); 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 93 if (ret) 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 94 return ret; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 95 f4710fdd10c9cf Alexandre Belloni 2020-04-15 @96 return buf[0] << 9 | buf[1] << 1 | buf[2] >> 7; 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 97 } 8dd2d7c0fed778 Gregory CLEMENT 2019-04-12 98 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
