CC: [email protected] TO: "Nikita, Travkin," <[email protected]> CC: Pavel Machek <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e7b08814b16b80a0bf76eeca16317f8c2ed23b8c commit: 59ea3c9faf3235b66bc31ca883d59ce58b8b2b27 [11624/14131] leds: add aw2013 driver :::::: branch date: 2 days ago :::::: commit date: 6 days ago config: arc-randconfig-m031-20200531 (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/leds/leds-aw2013.c:402 aw2013_probe() warn: inconsistent returns 'chip->mutex'. # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=59ea3c9faf3235b66bc31ca883d59ce58b8b2b27 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git remote update linux-next git checkout 59ea3c9faf3235b66bc31ca883d59ce58b8b2b27 vim +402 drivers/leds/leds-aw2013.c 59ea3c9faf3235 Nikita Travkin 2020-05-11 327 59ea3c9faf3235 Nikita Travkin 2020-05-11 328 static int aw2013_probe(struct i2c_client *client) 59ea3c9faf3235 Nikita Travkin 2020-05-11 329 { 59ea3c9faf3235 Nikita Travkin 2020-05-11 330 struct aw2013 *chip; 59ea3c9faf3235 Nikita Travkin 2020-05-11 331 int ret; 59ea3c9faf3235 Nikita Travkin 2020-05-11 332 unsigned int chipid; 59ea3c9faf3235 Nikita Travkin 2020-05-11 333 59ea3c9faf3235 Nikita Travkin 2020-05-11 334 chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); 59ea3c9faf3235 Nikita Travkin 2020-05-11 335 if (!chip) 59ea3c9faf3235 Nikita Travkin 2020-05-11 336 return -ENOMEM; 59ea3c9faf3235 Nikita Travkin 2020-05-11 337 59ea3c9faf3235 Nikita Travkin 2020-05-11 338 mutex_init(&chip->mutex); 59ea3c9faf3235 Nikita Travkin 2020-05-11 339 mutex_lock(&chip->mutex); 59ea3c9faf3235 Nikita Travkin 2020-05-11 340 59ea3c9faf3235 Nikita Travkin 2020-05-11 341 chip->client = client; 59ea3c9faf3235 Nikita Travkin 2020-05-11 342 i2c_set_clientdata(client, chip); 59ea3c9faf3235 Nikita Travkin 2020-05-11 343 59ea3c9faf3235 Nikita Travkin 2020-05-11 344 chip->regmap = devm_regmap_init_i2c(client, &aw2013_regmap_config); 59ea3c9faf3235 Nikita Travkin 2020-05-11 345 if (IS_ERR(chip->regmap)) { 59ea3c9faf3235 Nikita Travkin 2020-05-11 346 ret = PTR_ERR(chip->regmap); 59ea3c9faf3235 Nikita Travkin 2020-05-11 347 dev_err(&client->dev, "Failed to allocate register map: %d\n", 59ea3c9faf3235 Nikita Travkin 2020-05-11 348 ret); 59ea3c9faf3235 Nikita Travkin 2020-05-11 349 goto error; 59ea3c9faf3235 Nikita Travkin 2020-05-11 350 } 59ea3c9faf3235 Nikita Travkin 2020-05-11 351 59ea3c9faf3235 Nikita Travkin 2020-05-11 352 chip->vcc_regulator = devm_regulator_get(&client->dev, "vcc"); 59ea3c9faf3235 Nikita Travkin 2020-05-11 353 ret = PTR_ERR_OR_ZERO(chip->vcc_regulator); 59ea3c9faf3235 Nikita Travkin 2020-05-11 354 if (ret) { 59ea3c9faf3235 Nikita Travkin 2020-05-11 355 if (ret != -EPROBE_DEFER) 59ea3c9faf3235 Nikita Travkin 2020-05-11 356 dev_err(&client->dev, 59ea3c9faf3235 Nikita Travkin 2020-05-11 357 "Failed to request regulator: %d\n", ret); 59ea3c9faf3235 Nikita Travkin 2020-05-11 358 goto error; 59ea3c9faf3235 Nikita Travkin 2020-05-11 359 } 59ea3c9faf3235 Nikita Travkin 2020-05-11 360 59ea3c9faf3235 Nikita Travkin 2020-05-11 361 ret = regulator_enable(chip->vcc_regulator); 59ea3c9faf3235 Nikita Travkin 2020-05-11 362 if (ret) { 59ea3c9faf3235 Nikita Travkin 2020-05-11 363 dev_err(&client->dev, 59ea3c9faf3235 Nikita Travkin 2020-05-11 364 "Failed to enable regulator: %d\n", ret); 59ea3c9faf3235 Nikita Travkin 2020-05-11 365 goto error; 59ea3c9faf3235 Nikita Travkin 2020-05-11 366 } 59ea3c9faf3235 Nikita Travkin 2020-05-11 367 59ea3c9faf3235 Nikita Travkin 2020-05-11 368 ret = regmap_read(chip->regmap, AW2013_RSTR, &chipid); 59ea3c9faf3235 Nikita Travkin 2020-05-11 369 if (ret) { 59ea3c9faf3235 Nikita Travkin 2020-05-11 370 dev_err(&client->dev, "Failed to read chip ID: %d\n", 59ea3c9faf3235 Nikita Travkin 2020-05-11 371 ret); 59ea3c9faf3235 Nikita Travkin 2020-05-11 372 goto error_reg; 59ea3c9faf3235 Nikita Travkin 2020-05-11 373 } 59ea3c9faf3235 Nikita Travkin 2020-05-11 374 59ea3c9faf3235 Nikita Travkin 2020-05-11 375 if (chipid != AW2013_RSTR_CHIP_ID) { 59ea3c9faf3235 Nikita Travkin 2020-05-11 376 dev_err(&client->dev, "Chip reported wrong ID: %x\n", 59ea3c9faf3235 Nikita Travkin 2020-05-11 377 chipid); 59ea3c9faf3235 Nikita Travkin 2020-05-11 378 ret = -ENODEV; 59ea3c9faf3235 Nikita Travkin 2020-05-11 379 goto error_reg; 59ea3c9faf3235 Nikita Travkin 2020-05-11 380 } 59ea3c9faf3235 Nikita Travkin 2020-05-11 381 59ea3c9faf3235 Nikita Travkin 2020-05-11 382 ret = aw2013_probe_dt(chip); 59ea3c9faf3235 Nikita Travkin 2020-05-11 383 if (ret < 0) 59ea3c9faf3235 Nikita Travkin 2020-05-11 384 goto error_reg; 59ea3c9faf3235 Nikita Travkin 2020-05-11 385 59ea3c9faf3235 Nikita Travkin 2020-05-11 386 ret = regulator_disable(chip->vcc_regulator); 59ea3c9faf3235 Nikita Travkin 2020-05-11 387 if (ret) { 59ea3c9faf3235 Nikita Travkin 2020-05-11 388 dev_err(&client->dev, 59ea3c9faf3235 Nikita Travkin 2020-05-11 389 "Failed to disable regulator: %d\n", ret); 59ea3c9faf3235 Nikita Travkin 2020-05-11 390 goto error; 59ea3c9faf3235 Nikita Travkin 2020-05-11 391 } 59ea3c9faf3235 Nikita Travkin 2020-05-11 392 59ea3c9faf3235 Nikita Travkin 2020-05-11 393 mutex_unlock(&chip->mutex); 59ea3c9faf3235 Nikita Travkin 2020-05-11 394 59ea3c9faf3235 Nikita Travkin 2020-05-11 395 return 0; 59ea3c9faf3235 Nikita Travkin 2020-05-11 396 59ea3c9faf3235 Nikita Travkin 2020-05-11 397 error_reg: 59ea3c9faf3235 Nikita Travkin 2020-05-11 398 regulator_disable(chip->vcc_regulator); 59ea3c9faf3235 Nikita Travkin 2020-05-11 399 59ea3c9faf3235 Nikita Travkin 2020-05-11 400 error: 59ea3c9faf3235 Nikita Travkin 2020-05-11 401 mutex_destroy(&chip->mutex); 59ea3c9faf3235 Nikita Travkin 2020-05-11 @402 return ret; 59ea3c9faf3235 Nikita Travkin 2020-05-11 403 } 59ea3c9faf3235 Nikita Travkin 2020-05-11 404 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
