CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Dan Murphy <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: Dan Murphy <[email protected]>
Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on pavel-linux-leds/for-next] [also build test WARNING on robh/for-next linus/master v5.7 next-20200603] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework-v25/20200527-011531 base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next :::::: branch date: 8 days ago :::::: commit date: 8 days ago config: x86_64-randconfig-m001-20200603 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/leds/leds-lp5521.c:368 lp5521_multicolor_brightness() error: uninitialized symbol 'ret'. # https://github.com/0day-ci/linux/commit/4297261a2bd924d5e3a44ab5bb307e1835ec70cf git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 4297261a2bd924d5e3a44ab5bb307e1835ec70cf vim +/ret +368 drivers/leds/leds-lp5521.c 500fe141367e52 Samu Onkalo 2010-11-11 351 4297261a2bd924 Dan Murphy 2020-05-26 352 static int lp5521_multicolor_brightness(struct lp55xx_led *led) 4297261a2bd924 Dan Murphy 2020-05-26 353 { 4297261a2bd924 Dan Murphy 2020-05-26 354 struct lp55xx_chip *chip = led->chip; 4297261a2bd924 Dan Murphy 2020-05-26 355 int ret; 4297261a2bd924 Dan Murphy 2020-05-26 356 int i; 4297261a2bd924 Dan Murphy 2020-05-26 357 4297261a2bd924 Dan Murphy 2020-05-26 358 mutex_lock(&chip->lock); 4297261a2bd924 Dan Murphy 2020-05-26 359 for (i = 0; i < led->mc_cdev.num_colors; i++) { 4297261a2bd924 Dan Murphy 2020-05-26 360 ret = lp55xx_write(chip, 4297261a2bd924 Dan Murphy 2020-05-26 361 LP5521_REG_LED_PWM_BASE + 4297261a2bd924 Dan Murphy 2020-05-26 362 led->mc_cdev.subled_info[i].channel, 4297261a2bd924 Dan Murphy 2020-05-26 363 led->mc_cdev.subled_info[i].brightness); 4297261a2bd924 Dan Murphy 2020-05-26 364 if (ret) 4297261a2bd924 Dan Murphy 2020-05-26 365 break; 4297261a2bd924 Dan Murphy 2020-05-26 366 } 4297261a2bd924 Dan Murphy 2020-05-26 367 mutex_unlock(&chip->lock); 4297261a2bd924 Dan Murphy 2020-05-26 @368 return ret; 4297261a2bd924 Dan Murphy 2020-05-26 369 } 4297261a2bd924 Dan Murphy 2020-05-26 370 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
