CC: [email protected] TO: "Hannes, Reinecke," <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git xarray.v4 head: 4196b2277d94baee7703987a4a6b9c30214e0da7 commit: 09daf52178d6ccc51b7413ef9f960f83b66a4f27 [4/6] scsi: remove direct device lookup per host :::::: branch date: 2 days ago :::::: commit date: 2 days ago config: i386-randconfig-m021-20200603 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/scsi/scsi_scan.c:1878 scsi_forget_host() error: double unlocked '*shost->host_lock' (orig line 1870) drivers/scsi/scsi_sysfs.c:1508 __scsi_remove_target() error: double unlocked '*shost->host_lock' (orig line 1502) Old smatch warnings: drivers/scsi/scsi_sysfs.c:349 store_shost_eh_deadline() warn: impossible condition '(deadline * 1000 > (~0)) => (0-u32max > u32max)' drivers/scsi/scsi_sysfs.c:1550 scsi_remove_target() error: double unlocked '*shost->host_lock' (orig line 1543) # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=09daf52178d6ccc51b7413ef9f960f83b66a4f27 git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git git remote update hare-scsi-devel git checkout 09daf52178d6ccc51b7413ef9f960f83b66a4f27 vim +1878 drivers/scsi/scsi_scan.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 1850 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1851 void scsi_forget_host(struct Scsi_Host *shost) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1852 { 09daf52178d6cc Hannes Reinecke 2020-05-27 1853 struct scsi_target *starget, *starget_next; 09daf52178d6cc Hannes Reinecke 2020-05-27 1854 struct scsi_device *sdev, *sdev_next; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1855 unsigned long flags; 09daf52178d6cc Hannes Reinecke 2020-05-27 1856 unsigned long tid = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1857 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1858 spin_lock_irqsave(shost->host_lock, flags); 09daf52178d6cc Hannes Reinecke 2020-05-27 1859 starget = xa_find(&shost->__targets, &tid, UINT_MAX, XA_PRESENT); 09daf52178d6cc Hannes Reinecke 2020-05-27 1860 while (starget) { 09daf52178d6cc Hannes Reinecke 2020-05-27 1861 unsigned long lun_idx = 0; 09daf52178d6cc Hannes Reinecke 2020-05-27 1862 09daf52178d6cc Hannes Reinecke 2020-05-27 1863 starget_next = xa_find_after(&shost->__targets, &tid, UINT_MAX, XA_PRESENT); 09daf52178d6cc Hannes Reinecke 2020-05-27 1864 09daf52178d6cc Hannes Reinecke 2020-05-27 1865 sdev = xa_find(&starget->__devices, &lun_idx, UINT_MAX, XA_PRESENT); 09daf52178d6cc Hannes Reinecke 2020-05-27 1866 while (sdev) { 09daf52178d6cc Hannes Reinecke 2020-05-27 1867 sdev_next = xa_find_after(&starget->__devices, &lun_idx, UINT_MAX, XA_PRESENT); 09daf52178d6cc Hannes Reinecke 2020-05-27 1868 09daf52178d6cc Hannes Reinecke 2020-05-27 1869 if (sdev->sdev_state != SDEV_DEL) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 @1870 spin_unlock_irqrestore(shost->host_lock, flags); a64358db1253b3 Alan Stern 2005-07-26 1871 __scsi_remove_device(sdev); 09daf52178d6cc Hannes Reinecke 2020-05-27 1872 spin_lock_irqsave(shost->host_lock, flags); 09daf52178d6cc Hannes Reinecke 2020-05-27 1873 } 09daf52178d6cc Hannes Reinecke 2020-05-27 1874 sdev = sdev_next; 09daf52178d6cc Hannes Reinecke 2020-05-27 1875 } 09daf52178d6cc Hannes Reinecke 2020-05-27 1876 starget = starget_next; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1877 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 @1878 spin_unlock_irqrestore(shost->host_lock, flags); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1879 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1880 :::::: The code at line 1878 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds <[email protected]> :::::: CC: Linus Torvalds <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
