CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Harshad Shirwadkar <[email protected]> TO: [email protected] CC: Harshad Shirwadkar <[email protected]>
Hi Harshad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ext4/dev] [also build test WARNING on linus/master v5.7 next-20200605] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Harshad-Shirwadkar/ext4-issue-aligned-discards/20200606-062859 base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev :::::: branch date: 10 hours ago :::::: commit date: 10 hours ago config: x86_64-randconfig-m001-20200606 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: fs/ext4/mballoc.c:2892 ext4_issue_discard() warn: should '(count << (EXT4_SB(sb))->s_cluster_bits) << sb->s_blocksize_bits' be a 64 bit type? Old smatch warnings: fs/ext4/mballoc.c:1513 mb_free_blocks() warn: should 'block << sbi->s_cluster_bits' be a 64 bit type? fs/ext4/mballoc.c:4572 ext4_mb_release_context() warn: should '(ac->ac_b_ex.fe_len) << sbi->s_cluster_bits' be a 64 bit type? # https://github.com/0day-ci/linux/commit/0f8171737cc63a003f5ea31602ff655601770350 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 0f8171737cc63a003f5ea31602ff655601770350 vim +2892 fs/ext4/mballoc.c c9de560ded61fa Alex Tomas 2008-01-29 2878 77ca6cdf0ab8a4 Lukas Czerner 2010-10-27 2879 static inline int ext4_issue_discard(struct super_block *sb, a015434480dcdb Daeho Jeong 2017-06-22 2880 ext4_group_t block_group, ext4_grpblk_t cluster, int count, a015434480dcdb Daeho Jeong 2017-06-22 2881 struct bio **biop) 5c521830cf3dfc Jiaying Zhang 2010-07-27 2882 { 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2883 unsigned long long discard_start, discard_len, alignment, granularity, 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2884 aligned_discard_start; 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2885 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2886 granularity = max(bdev_discard_granularity(sb->s_bdev), 1 << 9); 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2887 alignment = max_t(int, bdev_logical_block_size(sb->s_bdev), 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2888 bdev_discard_alignment(sb->s_bdev)); 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2889 discard_start = (EXT4_C2B(EXT4_SB(sb), cluster) + 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2890 ext4_group_first_block_no(sb, block_group)) << 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2891 sb->s_blocksize_bits; 0f8171737cc63a Harshad Shirwadkar 2020-06-05 @2892 discard_len = EXT4_C2B(EXT4_SB(sb), count) << sb->s_blocksize_bits; 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2893 aligned_discard_start = round_up(discard_start, alignment); 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2894 discard_len -= min(discard_len, aligned_discard_start - discard_start); 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2895 discard_len = round_down(discard_len, granularity); 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2896 if (discard_len >> 9 == 0) 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2897 return 0; 5c521830cf3dfc Jiaying Zhang 2010-07-27 2898 trace_ext4_discard_blocks(sb, 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2899 aligned_discard_start >> sb->s_blocksize_bits, 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2900 discard_len >> (sb->s_blocksize_bits)); 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2901 if (biop) a015434480dcdb Daeho Jeong 2017-06-22 2902 return __blkdev_issue_discard(sb->s_bdev, 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2903 aligned_discard_start >> 9, discard_len >> 9, a015434480dcdb Daeho Jeong 2017-06-22 2904 GFP_NOFS, 0, biop); 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2905 return sb_issue_discard(sb, aligned_discard_start, discard_len, 0f8171737cc63a Harshad Shirwadkar 2020-06-05 2906 GFP_NOFS, 0); 5c521830cf3dfc Jiaying Zhang 2010-07-27 2907 } 5c521830cf3dfc Jiaying Zhang 2010-07-27 2908 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
