CC: [email protected]
CC: [email protected]
TO: Richard Cochran <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   9fa88c5d3f5eae3e68ef20d226c3f13e21490668
commit: bad1eaa6ac312ffd7aa46dd5a4d9843b824aa023 ptp: Add a driver for InES 
time stamping IP core.
date:   5 months ago
:::::: branch date: 2 hours ago
:::::: commit date: 5 months ago
config: i386-randconfig-m021-20200607 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/ptp/ptp_ines.c:664 ines_txtstamp() error: double unlocked 'port->lock' 
(orig line 652)

# 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bad1eaa6ac312ffd7aa46dd5a4d9843b824aa023
git remote add linus 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout bad1eaa6ac312ffd7aa46dd5a4d9843b824aa023
vim +664 drivers/ptp/ptp_ines.c

bad1eaa6ac312f Richard Cochran 2019-12-25  644  
bad1eaa6ac312f Richard Cochran 2019-12-25  645  static void 
ines_txtstamp(struct mii_timestamper *mii_ts,
bad1eaa6ac312f Richard Cochran 2019-12-25  646                            
struct sk_buff *skb, int type)
bad1eaa6ac312f Richard Cochran 2019-12-25  647  {
bad1eaa6ac312f Richard Cochran 2019-12-25  648          struct ines_port *port 
= container_of(mii_ts, struct ines_port, mii_ts);
bad1eaa6ac312f Richard Cochran 2019-12-25  649          struct sk_buff *old_skb 
= NULL;
bad1eaa6ac312f Richard Cochran 2019-12-25  650          unsigned long flags;
bad1eaa6ac312f Richard Cochran 2019-12-25  651  
bad1eaa6ac312f Richard Cochran 2019-12-25 @652          if (!port->txts_enabled 
|| ines_txts_onestep(port, skb, type)) {
bad1eaa6ac312f Richard Cochran 2019-12-25  653                  kfree_skb(skb);
bad1eaa6ac312f Richard Cochran 2019-12-25  654                  return;
bad1eaa6ac312f Richard Cochran 2019-12-25  655          }
bad1eaa6ac312f Richard Cochran 2019-12-25  656  
bad1eaa6ac312f Richard Cochran 2019-12-25  657          
spin_lock_irqsave(&port->lock, flags);
bad1eaa6ac312f Richard Cochran 2019-12-25  658  
bad1eaa6ac312f Richard Cochran 2019-12-25  659          if (port->tx_skb)
bad1eaa6ac312f Richard Cochran 2019-12-25  660                  old_skb = 
port->tx_skb;
bad1eaa6ac312f Richard Cochran 2019-12-25  661  
bad1eaa6ac312f Richard Cochran 2019-12-25  662          port->tx_skb = skb;
bad1eaa6ac312f Richard Cochran 2019-12-25  663  
bad1eaa6ac312f Richard Cochran 2019-12-25 @664          
spin_unlock_irqrestore(&port->lock, flags);
bad1eaa6ac312f Richard Cochran 2019-12-25  665  
bad1eaa6ac312f Richard Cochran 2019-12-25  666          if (old_skb)
bad1eaa6ac312f Richard Cochran 2019-12-25  667                  
kfree_skb(old_skb);
bad1eaa6ac312f Richard Cochran 2019-12-25  668  
bad1eaa6ac312f Richard Cochran 2019-12-25  669          
schedule_delayed_work(&port->ts_work, 1);
bad1eaa6ac312f Richard Cochran 2019-12-25  670  }
bad1eaa6ac312f Richard Cochran 2019-12-25  671  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to