CC: [email protected] CC: [email protected] TO: YueHaibing <[email protected]> CC: "Greg Kroah-Hartman" <[email protected]> CC: Stephen Boyd <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: af7b4801030c07637840191c69eb666917e4135d commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error date: 9 months ago :::::: branch date: 5 hours ago :::::: commit date: 9 months ago config: i386-randconfig-c024-20200607 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Julia Lawall <[email protected]> coccinelle warnings: (new ones prefixed by >>) >> drivers/i2c/busses/i2c-pxa.c:1222:2-9: line 1222 is redundant because >> platform_get_irq() already prints an error # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git remote update linus git checkout ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c vim +1222 drivers/i2c/busses/i2c-pxa.c 63fe122bce0655 Haojian Zhuang 2012-03-01 1202 63fe122bce0655 Haojian Zhuang 2012-03-01 1203 static int i2c_pxa_probe(struct platform_device *dev) 63fe122bce0655 Haojian Zhuang 2012-03-01 1204 { 6d4028c644edc0 Jingoo Han 2013-07-30 1205 struct i2c_pxa_platform_data *plat = dev_get_platdata(&dev->dev); 63fe122bce0655 Haojian Zhuang 2012-03-01 1206 enum pxa_i2c_types i2c_type; 63fe122bce0655 Haojian Zhuang 2012-03-01 1207 struct pxa_i2c *i2c; 63fe122bce0655 Haojian Zhuang 2012-03-01 1208 struct resource *res = NULL; 63fe122bce0655 Haojian Zhuang 2012-03-01 1209 int ret, irq; a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1210 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1211 i2c = devm_kzalloc(&dev->dev, sizeof(struct pxa_i2c), GFP_KERNEL); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1212 if (!i2c) 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1213 return -ENOMEM; 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1214 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1215 res = platform_get_resource(dev, IORESOURCE_MEM, 0); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1216 i2c->reg_base = devm_ioremap_resource(&dev->dev, res); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1217 if (IS_ERR(i2c->reg_base)) 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1218 return PTR_ERR(i2c->reg_base); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1219 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1220 irq = platform_get_irq(dev, 0); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1221 if (irq < 0) { 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 @1222 dev_err(&dev->dev, "no irq resource: %d\n", irq); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1223 return irq; a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1224 } a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1225 fe69c555ef4df4 Doug Anderson 2013-03-01 1226 /* Default adapter num to device id; i2c_pxa_probe_dt can override. */ fe69c555ef4df4 Doug Anderson 2013-03-01 1227 i2c->adap.nr = dev->id; fe69c555ef4df4 Doug Anderson 2013-03-01 1228 63fe122bce0655 Haojian Zhuang 2012-03-01 1229 ret = i2c_pxa_probe_dt(dev, i2c, &i2c_type); 63fe122bce0655 Haojian Zhuang 2012-03-01 1230 if (ret > 0) 63fe122bce0655 Haojian Zhuang 2012-03-01 1231 ret = i2c_pxa_probe_pdata(dev, i2c, &i2c_type); 63fe122bce0655 Haojian Zhuang 2012-03-01 1232 if (ret < 0) 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1233 return ret; 63fe122bce0655 Haojian Zhuang 2012-03-01 1234 6776f3d26aec60 Enrico Scholz 2007-05-21 1235 i2c->adap.owner = THIS_MODULE; 6776f3d26aec60 Enrico Scholz 2007-05-21 1236 i2c->adap.retries = 5; 6776f3d26aec60 Enrico Scholz 2007-05-21 1237 6776f3d26aec60 Enrico Scholz 2007-05-21 1238 spin_lock_init(&i2c->lock); a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1239 init_waitqueue_head(&i2c->wait); 6776f3d26aec60 Enrico Scholz 2007-05-21 1240 fe69c555ef4df4 Doug Anderson 2013-03-01 1241 strlcpy(i2c->adap.name, "pxa_i2c-i2c", sizeof(i2c->adap.name)); a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1242 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1243 i2c->clk = devm_clk_get(&dev->dev, NULL); c3cef3f3c07bb9 Russell King 2007-08-20 1244 if (IS_ERR(i2c->clk)) { 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1245 dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk)); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1246 return PTR_ERR(i2c->clk); a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1247 } d6668c7cd4defd Sebastian Andrzej Siewior 2011-02-23 1248 d6668c7cd4defd Sebastian Andrzej Siewior 2011-02-23 1249 i2c->reg_ibmr = i2c->reg_base + pxa_reg_layout[i2c_type].ibmr; d6668c7cd4defd Sebastian Andrzej Siewior 2011-02-23 1250 i2c->reg_idbr = i2c->reg_base + pxa_reg_layout[i2c_type].idbr; d6668c7cd4defd Sebastian Andrzej Siewior 2011-02-23 1251 i2c->reg_icr = i2c->reg_base + pxa_reg_layout[i2c_type].icr; d6668c7cd4defd Sebastian Andrzej Siewior 2011-02-23 1252 i2c->reg_isr = i2c->reg_base + pxa_reg_layout[i2c_type].isr; 6c14bdacdb29c3 Romain Perier 2016-12-01 1253 i2c->fm_mask = pxa_reg_layout[i2c_type].fm ? : ICR_FM; 6c14bdacdb29c3 Romain Perier 2016-12-01 1254 i2c->hs_mask = pxa_reg_layout[i2c_type].hs ? : ICR_HS; 6c14bdacdb29c3 Romain Perier 2016-12-01 1255 7e94dd154e934a Sebastian Andrzej Siewior 2011-03-02 1256 if (i2c_type != REGS_CE4100) d6668c7cd4defd Sebastian Andrzej Siewior 2011-02-23 1257 i2c->reg_isar = i2c->reg_base + pxa_reg_layout[i2c_type].isar; a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1258 c5fa6fc79f5b1f Vaibhav Hiremath 2015-08-24 1259 if (i2c_type == REGS_PXA910) { c5fa6fc79f5b1f Vaibhav Hiremath 2015-08-24 1260 i2c->reg_ilcr = i2c->reg_base + pxa_reg_layout[i2c_type].ilcr; c5fa6fc79f5b1f Vaibhav Hiremath 2015-08-24 1261 i2c->reg_iwcr = i2c->reg_base + pxa_reg_layout[i2c_type].iwcr; c5fa6fc79f5b1f Vaibhav Hiremath 2015-08-24 1262 } c5fa6fc79f5b1f Vaibhav Hiremath 2015-08-24 1263 a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1264 i2c->iobase = res->start; c6ffddea36dd57 Linus Walleij 2009-06-14 1265 i2c->iosize = resource_size(res); a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1266 a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1267 i2c->irq = irq; b652b438fcad4c Russell King 2005-06-15 1268 b652b438fcad4c Russell King 2005-06-15 1269 i2c->slave_addr = I2C_PXA_SLAVE_ADDR; 9d3dda5c0d092d Leilei Shang 2013-06-07 1270 i2c->highmode_enter = false; b652b438fcad4c Russell King 2005-06-15 1271 b652b438fcad4c Russell King 2005-06-15 1272 if (plat) { 63fe122bce0655 Haojian Zhuang 2012-03-01 1273 #ifdef CONFIG_I2C_PXA_SLAVE b652b438fcad4c Russell King 2005-06-15 1274 i2c->slave_addr = plat->slave_addr; b652b438fcad4c Russell King 2005-06-15 1275 i2c->slave = plat->slave; b652b438fcad4c Russell King 2005-06-15 1276 #endif b7a3670131c766 Mike Rapoport 2008-01-27 1277 i2c->adap.class = plat->class; b7a3670131c766 Mike Rapoport 2008-01-27 1278 } b7a3670131c766 Mike Rapoport 2008-01-27 1279 9d3dda5c0d092d Leilei Shang 2013-06-07 1280 if (i2c->high_mode) { 9d3dda5c0d092d Leilei Shang 2013-06-07 1281 if (i2c->rate) { 9d3dda5c0d092d Leilei Shang 2013-06-07 1282 clk_set_rate(i2c->clk, i2c->rate); 9d3dda5c0d092d Leilei Shang 2013-06-07 1283 pr_info("i2c: <%s> set rate to %ld\n", 9d3dda5c0d092d Leilei Shang 2013-06-07 1284 i2c->adap.name, clk_get_rate(i2c->clk)); 9d3dda5c0d092d Leilei Shang 2013-06-07 1285 } else 9d3dda5c0d092d Leilei Shang 2013-06-07 1286 pr_warn("i2c: <%s> clock rate not set\n", 9d3dda5c0d092d Leilei Shang 2013-06-07 1287 i2c->adap.name); 9d3dda5c0d092d Leilei Shang 2013-06-07 1288 } 9d3dda5c0d092d Leilei Shang 2013-06-07 1289 7a10f4732972b4 Daniel Drake 2013-06-17 1290 clk_prepare_enable(i2c->clk); 63fe122bce0655 Haojian Zhuang 2012-03-01 1291 b7a3670131c766 Mike Rapoport 2008-01-27 1292 if (i2c->use_pio) { b7a3670131c766 Mike Rapoport 2008-01-27 1293 i2c->adap.algo = &i2c_pxa_pio_algorithm; b7a3670131c766 Mike Rapoport 2008-01-27 1294 } else { b7a3670131c766 Mike Rapoport 2008-01-27 1295 i2c->adap.algo = &i2c_pxa_algorithm; 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1296 ret = devm_request_irq(&dev->dev, irq, i2c_pxa_handler, abf8a1fba9a485 Leilei Shang 2015-07-14 1297 IRQF_SHARED | IRQF_NO_SUSPEND, fe69c555ef4df4 Doug Anderson 2013-03-01 1298 dev_name(&dev->dev), i2c); 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1299 if (ret) { 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1300 dev_err(&dev->dev, "failed to request irq: %d\n", ret); a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1301 goto ereqirq; b7a3670131c766 Mike Rapoport 2008-01-27 1302 } 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1303 } a7b4e5506d1608 Guennadi Liakhovetski 2007-02-08 1304 b652b438fcad4c Russell King 2005-06-15 1305 i2c_pxa_reset(i2c); b652b438fcad4c Russell King 2005-06-15 1306 b652b438fcad4c Russell King 2005-06-15 1307 i2c->adap.algo_data = i2c; 3ae5eaec1d2d9c Russell King 2005-11-09 1308 i2c->adap.dev.parent = &dev->dev; baa8cab012ff07 Sebastian Andrzej Siewior 2011-02-23 1309 #ifdef CONFIG_OF baa8cab012ff07 Sebastian Andrzej Siewior 2011-02-23 1310 i2c->adap.dev.of_node = dev->dev.of_node; baa8cab012ff07 Sebastian Andrzej Siewior 2011-02-23 1311 #endif b652b438fcad4c Russell King 2005-06-15 1312 066af983c74162 Rodolfo Giometti 2007-07-12 1313 ret = i2c_add_numbered_adapter(&i2c->adap); ea734404f3daf1 Wolfram Sang 2016-08-09 1314 if (ret < 0) 51fcce86a70f6f Vaibhav Hiremath 2015-07-14 1315 goto ereqirq; b652b438fcad4c Russell King 2005-06-15 1316 3ae5eaec1d2d9c Russell King 2005-11-09 1317 platform_set_drvdata(dev, i2c); b652b438fcad4c Russell King 2005-06-15 1318 :::::: The code at line 1222 was first introduced by commit :::::: 51fcce86a70f6f63d733619afc425821118838dc i2c: pxa: Use devm_ variants in probe function :::::: TO: Vaibhav Hiremath <[email protected]> :::::: CC: Wolfram Sang <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
