On Fri, Jun 05, 2020 at 02:20:12PM -0700, Kees Cook wrote: > On Fri, Jun 05, 2020 at 01:38:20PM +0300, kernel test robot wrote: > > smatch warnings: > > drivers/virtio/virtio_ring.c:1197 virtqueue_add_packed() error: > > uninitialized symbol 'prev'. > > drivers/virtio/virtio_ring.c:1205 virtqueue_add_packed() error: > > uninitialized symbol 'head_flags'. > > drivers/virtio/virtio_ring.c:508 virtqueue_add_split() error: uninitialized > > symbol 'prev'. > > Regardless, I'll see if I can get this explicitly initialized to avoid > the new smatch warnings.
I would prefer to leave it as-is rather than silencing it just for Smatch. Eventually Smatch will be able to parse these things correctly. My concern is that eventually GCC will re-enable their uninitialized variable warning and we will be flooded with warnings. Maybe when that happens we will disable the GCC check and only rely on Smatch, though so maybe that's a good thing. regards, dan carpenter _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
