CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Dan Murphy <[email protected]>
TO: [email protected]
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: Dan Murphy <[email protected]>

Hi Dan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pavel-linux-leds/for-next]
[also build test WARNING on robh/for-next v5.7 next-20200608]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework-v27/20200609-034319
base:   git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git 
for-next
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: x86_64-randconfig-m001-20200607 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/leds/leds-lp5523.c:810 lp5523_multicolor_brightness() error: 
uninitialized symbol 'ret'.

# 
https://github.com/0day-ci/linux/commit/9e1a8e50ad52b8552435409f69eed2d3155e903c
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 9e1a8e50ad52b8552435409f69eed2d3155e903c
vim +/ret +810 drivers/leds/leds-lp5523.c

52da81eafaff13 Toshi Kikuchi 2015-05-11  793  
9e1a8e50ad52b8 Dan Murphy    2020-06-08  794  static int 
lp5523_multicolor_brightness(struct lp55xx_led *led)
9e1a8e50ad52b8 Dan Murphy    2020-06-08  795  {
9e1a8e50ad52b8 Dan Murphy    2020-06-08  796    struct lp55xx_chip *chip = 
led->chip;
9e1a8e50ad52b8 Dan Murphy    2020-06-08  797    int ret;
9e1a8e50ad52b8 Dan Murphy    2020-06-08  798    int i;
9e1a8e50ad52b8 Dan Murphy    2020-06-08  799  
9e1a8e50ad52b8 Dan Murphy    2020-06-08  800    mutex_lock(&chip->lock);
9e1a8e50ad52b8 Dan Murphy    2020-06-08  801    for (i = 0; i < 
led->mc_cdev.num_colors; i++) {
9e1a8e50ad52b8 Dan Murphy    2020-06-08  802            ret = lp55xx_write(chip,
9e1a8e50ad52b8 Dan Murphy    2020-06-08  803                               
LP5523_REG_LED_PWM_BASE +
9e1a8e50ad52b8 Dan Murphy    2020-06-08  804                               
led->mc_cdev.subled_info[i].channel,
9e1a8e50ad52b8 Dan Murphy    2020-06-08  805                               
led->mc_cdev.subled_info[i].brightness);
9e1a8e50ad52b8 Dan Murphy    2020-06-08  806            if (ret)
9e1a8e50ad52b8 Dan Murphy    2020-06-08  807                    break;
9e1a8e50ad52b8 Dan Murphy    2020-06-08  808    }
9e1a8e50ad52b8 Dan Murphy    2020-06-08  809    mutex_unlock(&chip->lock);
9e1a8e50ad52b8 Dan Murphy    2020-06-08 @810    return ret;
9e1a8e50ad52b8 Dan Murphy    2020-06-08  811  }
9e1a8e50ad52b8 Dan Murphy    2020-06-08  812  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to